From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPfTH-0001y0-4D for qemu-devel@nongnu.org; Mon, 17 Mar 2014 17:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPfT8-0001fx-4J for qemu-devel@nongnu.org; Mon, 17 Mar 2014 17:53:22 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:43076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPfT7-0001fM-Q6 for qemu-devel@nongnu.org; Mon, 17 Mar 2014 17:53:14 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Mar 2014 21:53:12 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D02F12190041 for ; Mon, 17 Mar 2014 21:53:05 +0000 (GMT) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2HLqw2q66912386 for ; Mon, 17 Mar 2014 21:52:58 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2HLr9tf026995 for ; Mon, 17 Mar 2014 15:53:10 -0600 From: Christian Borntraeger Date: Mon, 17 Mar 2014 22:53:25 +0100 Message-Id: <1395093205-46337-1-git-send-email-borntraeger@de.ibm.com> Subject: [Qemu-devel] [PATCH] vl.c: Fix memory leak in qemu_register_machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Christian Borntraeger , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Marcel Apfelbaum since commit 261747f176f6 (vl: Use MachineClass instead of global QEMUMachine list) valgrind complains about the following: ==54082== 57 bytes in 3 blocks are definitely lost in loss record 365 of 729 ==54082== at 0x4031AFE: malloc (vg_replace_malloc.c:292) ==54082== by 0x4145569: g_malloc (in /usr/lib64/libglib-2.0.so.0.3400.2) ==54082== by 0x415F9E9: g_strconcat (in /usr/lib64/libglib-2.0.so.0.3400.2) ==54082== by 0x80157FE7: qemu_register_machine (vl.c:1597) ==54082== by 0x80208E6B: module_call_init (module.c:105) ==54082== by 0x80013B91: main (vl.c:3000) Turns out that valgrind is right. We simply forget the memory that g_strconcat has allocated. Lets free it after the type_register. Signed-off-by: Christian Borntraeger --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index b363a21..97290c9 100644 --- a/vl.c +++ b/vl.c @@ -1592,6 +1592,7 @@ int qemu_register_machine(QEMUMachine *m) }; type_register(&ti); + g_free((void *) ti.name); return 0; } -- 1.8.4.2