From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPfZJ-0005XW-3j for qemu-devel@nongnu.org; Mon, 17 Mar 2014 17:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPfZD-0003Uo-6L for qemu-devel@nongnu.org; Mon, 17 Mar 2014 17:59:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPfZC-0003Ui-UA for qemu-devel@nongnu.org; Mon, 17 Mar 2014 17:59:31 -0400 Message-ID: <1395093590.13766.2.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Mon, 17 Mar 2014 23:59:50 +0200 In-Reply-To: <1395093205-46337-1-git-send-email-borntraeger@de.ibm.com> References: <1395093205-46337-1-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vl.c: Fix memory leak in qemu_register_machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Peter Maydell , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , Andreas =?ISO-8859-1?Q?F=E4rber?= On Mon, 2014-03-17 at 22:53 +0100, Christian Borntraeger wrote: > since commit 261747f176f6 (vl: Use MachineClass instead of global > QEMUMachine list) valgrind complains about the following: > > ==54082== 57 bytes in 3 blocks are definitely lost in loss record 365 of 729 > ==54082== at 0x4031AFE: malloc (vg_replace_malloc.c:292) > ==54082== by 0x4145569: g_malloc (in /usr/lib64/libglib-2.0.so.0.3400.2) > ==54082== by 0x415F9E9: g_strconcat (in /usr/lib64/libglib-2.0.so.0.3400.2) > ==54082== by 0x80157FE7: qemu_register_machine (vl.c:1597) > ==54082== by 0x80208E6B: module_call_init (module.c:105) > ==54082== by 0x80013B91: main (vl.c:3000) > > Turns out that valgrind is right. We simply forget the memory that > g_strconcat has allocated. Lets free it after the type_register. > > Signed-off-by: Christian Borntraeger > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vl.c b/vl.c > index b363a21..97290c9 100644 > --- a/vl.c > +++ b/vl.c > @@ -1592,6 +1592,7 @@ int qemu_register_machine(QEMUMachine *m) > }; > > type_register(&ti); > + g_free((void *) ti.name); I would remove the ^ space here, but maybe Andreas can remove it when he applies it. Thanks again! Reviewed-by: Marcel Apfelbaum > > return 0; > }