From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/2] qcow2: Correct comment for realloc_refcount_block()
Date: Mon, 17 Mar 2014 23:04:51 +0100 [thread overview]
Message-ID: <1395093892-29271-2-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1395093892-29271-1-git-send-email-mreitz@redhat.com>
Contrary to the comment describing this function's behavior, it does not
return 0 on success, but rather the offset of the newly allocated
cluster. This patch adjusts the comment accordingly to reflect the
actual behavior.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2-refcount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 6151148..3f2ed08 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -1383,7 +1383,7 @@ static int write_reftable_entry(BlockDriverState *bs, int rt_index)
* does _not_ decrement the reference count for the currently occupied cluster.
*
* This function prints an informative message to stderr on error (and returns
- * -errno); on success, 0 is returned.
+ * -errno); on success, the offset of the newly allocated cluster is returned.
*/
static int64_t realloc_refcount_block(BlockDriverState *bs, int reftable_index,
uint64_t offset)
--
1.9.0
next prev parent reply other threads:[~2014-03-17 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 22:04 [Qemu-devel] [PATCH v2 0/2] qcow2: Fix return path of realloc_refcount_block() Max Reitz
2014-03-17 22:04 ` Max Reitz [this message]
2014-03-17 22:19 ` [Qemu-devel] [PATCH v2 1/2] qcow2: Correct comment for realloc_refcount_block() Laszlo Ersek
2014-03-17 22:04 ` [Qemu-devel] [PATCH v2 2/2] qcow2: Fix fail path in realloc_refcount_block() Max Reitz
2014-03-17 22:18 ` Laszlo Ersek
2014-03-18 9:32 ` Kevin Wolf
2014-03-18 9:33 ` [Qemu-devel] [PATCH v2 0/2] qcow2: Fix return path of realloc_refcount_block() Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395093892-29271-2-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).