From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPfed-0003oy-RY for qemu-devel@nongnu.org; Mon, 17 Mar 2014 18:05:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPfeX-0005Cw-Ss for qemu-devel@nongnu.org; Mon, 17 Mar 2014 18:05:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPfeX-00058R-KX for qemu-devel@nongnu.org; Mon, 17 Mar 2014 18:05:01 -0400 From: Max Reitz Date: Mon, 17 Mar 2014 23:04:51 +0100 Message-Id: <1395093892-29271-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1395093892-29271-1-git-send-email-mreitz@redhat.com> References: <1395093892-29271-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/2] qcow2: Correct comment for realloc_refcount_block() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Laszlo Ersek , =?UTF-8?q?Beno=C3=AEt=20Canet?= , Stefan Hajnoczi , Max Reitz Contrary to the comment describing this function's behavior, it does not return 0 on success, but rather the offset of the newly allocated cluster. This patch adjusts the comment accordingly to reflect the actual behavior. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 6151148..3f2ed08 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -1383,7 +1383,7 @@ static int write_reftable_entry(BlockDriverState *bs, int rt_index) * does _not_ decrement the reference count for the currently occupied cluster. * * This function prints an informative message to stderr on error (and returns - * -errno); on success, 0 is returned. + * -errno); on success, the offset of the newly allocated cluster is returned. */ static int64_t realloc_refcount_block(BlockDriverState *bs, int reftable_index, uint64_t offset) -- 1.9.0