qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Maria Kustova <maxa@catit.be>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-trivial@nongnu.org,
	Maria Kustova <maria.k@catit.be>,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 3/3] qemu-io: Extended "--cmd" description in usage text
Date: Tue, 18 Mar 2014 09:59:19 +0400	[thread overview]
Message-ID: <1395122359-28890-4-git-send-email-maria.k@catit.be> (raw)
In-Reply-To: <1395122359-28890-1-git-send-email-maria.k@catit.be>

It's not clear from the usage description that "--cmd" option accepts its argument as a string, so any special symbols have to be quoted from the shell.
Updates in usage text:
 - Specified parameter format for "--cmd" option.
 - Added an instruction how to get help for "--cmd" option.

Signed-off-by: Maria Kustova <maria.k@catit.be>
---
 qemu-io.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/qemu-io.c b/qemu-io.c
index fc38608..be68d96 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -194,10 +194,11 @@ static const cmdinfo_t quit_cmd = {
 static void usage(const char *name)
 {
     printf(
-"Usage: %s [-h] [-V] [-rsnm] [-c cmd] ... [file]\n"
+"Usage: %s [-h] [-V] [-rsnm] [-c STRING] ... [file]\n"
 "QEMU Disk exerciser\n"
 "\n"
-"  -c, --cmd            command to execute\n"
+"  -c, --cmd STRING     execute command with its arguments\n"
+"                       from the given string\n"
 "  -r, --read-only      export read-only\n"
 "  -s, --snapshot       use snapshot file\n"
 "  -n, --nocache        disable host cache\n"
@@ -208,8 +209,10 @@ static void usage(const char *name)
 "  -T, --trace FILE     enable trace events listed in the given file\n"
 "  -h, --help           display this help and exit\n"
 "  -V, --version        output version information and exit\n"
+"\n"
+"See '%s -c help' for information on available commands."
 "\n",
-    name);
+    name, name);
 }
 
 static char *get_prompt(void)
-- 
1.8.2.1

  parent reply	other threads:[~2014-03-18  6:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18  5:59 [Qemu-devel] [PATCH v2 0/3] Trivial patches Maria Kustova
2014-03-18  5:59 ` [Qemu-devel] [PATCH v2 1/3] qemu-io-cmds: Fixed typo in example for writev Maria Kustova
2014-03-18  5:59 ` [Qemu-devel] [PATCH v2 2/3] block: Replaced old error handling with error reporting API Maria Kustova
2014-03-18  9:20   ` Kevin Wolf
2014-03-18  5:59 ` Maria Kustova [this message]
2014-03-18  9:19   ` [Qemu-devel] [PATCH v2 3/3] qemu-io: Extended "--cmd" description in usage text Kevin Wolf
2014-03-18  9:18 ` [Qemu-devel] [PATCH v2 0/3] Trivial patches Kevin Wolf
2014-03-18  9:37 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395122359-28890-4-git-send-email-maria.k@catit.be \
    --to=maxa@catit.be \
    --cc=kwolf@redhat.com \
    --cc=maria.k@catit.be \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).