From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPxEJ-0005zg-H2 for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:51:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPxED-0002MM-IB for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:51:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPxED-0002ME-A1 for qemu-devel@nongnu.org; Tue, 18 Mar 2014 12:51:01 -0400 From: Stefan Hajnoczi Date: Tue, 18 Mar 2014 17:50:52 +0100 Message-Id: <1395161452-5123-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH for-2.0] dataplane: fix implicit IOThread refcount List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi When creating an IOThread implicitly (the user did not specify x-iothread=) remember that iothread_find() does not return the object with an incremented refcount. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index a5afc21..f558b45 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -393,7 +393,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, if (blk->iothread) { s->internal_iothread = false; s->iothread = blk->iothread; - object_ref(OBJECT(s->iothread)); } else { /* Create per-device IOThread if none specified */ Error *local_err = NULL; @@ -408,6 +407,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, s->iothread = iothread_find(vdev->name); assert(s->iothread); } + object_ref(OBJECT(s->iothread)); s->ctx = iothread_get_aio_context(s->iothread); /* Prevent block operations that conflict with data plane thread */ -- 1.8.5.3