From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, agraf@suse.de, armbru@redhat.com,
gsomlo@gmail.com, kevin@koconnor.net, kraxel@redhat.com,
imammedo@redhat.com, lersek@redhat.com
Subject: [Qemu-devel] [v4 PATCH 05/12] SMBIOS: Build full tables for types 0 and 1
Date: Tue, 18 Mar 2014 19:23:22 -0400 [thread overview]
Message-ID: <1395185009-26532-6-git-send-email-somlo@cmu.edu> (raw)
In-Reply-To: <1395185009-26532-1-git-send-email-somlo@cmu.edu>
Build full tables for types 0 (bios information) and 1 (system
information). Type 0 is optional, and a table will only be built
if requested via the command line; the default is to leave type 0
tables up to the bios itself.
Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
---
hw/i386/smbios.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 06f572d..b00a367 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -352,6 +352,62 @@ static void smbios_build_type_1_fields(void)
}
}
+static void smbios_build_type_0_table(void)
+{
+ SMBIOS_BUILD_TABLE_PRE(0, 0x000, false); /* optional, leave up to BIOS */
+
+ SMBIOS_TABLE_SET_STR(0, vendor_str, type0.vendor);
+ SMBIOS_TABLE_SET_STR(0, bios_version_str, type0.version);
+
+ t->bios_starting_address_segment = 0xE800; /* hardcoded in SeaBIOS */
+
+ SMBIOS_TABLE_SET_STR(0, bios_release_date_str, type0.date);
+
+ t->bios_rom_size = 0; /* hardcoded in SeaBIOS with FIXME comment */
+
+ /* BIOS characteristics not supported */
+ memset(t->bios_characteristics, 0, 8);
+ t->bios_characteristics[0] = 0x08;
+
+ /* Enable targeted content distribution (needed for SVVP, per SeaBIOS) */
+ t->bios_characteristics_extension_bytes[0] = 0;
+ t->bios_characteristics_extension_bytes[1] = 4;
+
+ if (type0.have_major_minor) {
+ t->system_bios_major_release = type0.major;
+ t->system_bios_minor_release = type0.minor;
+ } else {
+ t->system_bios_major_release = 0;
+ t->system_bios_minor_release = 0;
+ }
+
+ /* hardcoded in SeaBIOS */
+ t->embedded_controller_major_release = 0xFF;
+ t->embedded_controller_minor_release = 0xFF;
+
+ SMBIOS_BUILD_TABLE_POST;
+}
+
+static void smbios_build_type_1_table(void)
+{
+ SMBIOS_BUILD_TABLE_PRE(1, 0x100, true); /* required */
+
+ SMBIOS_TABLE_SET_STR(1, manufacturer_str, type1.manufacturer);
+ SMBIOS_TABLE_SET_STR(1, product_name_str, type1.product);
+ SMBIOS_TABLE_SET_STR(1, version_str, type1.version);
+ SMBIOS_TABLE_SET_STR(1, serial_number_str, type1.serial);
+ if (qemu_uuid_set) {
+ memcpy(t->uuid, qemu_uuid, 16);
+ } else {
+ memset(t->uuid, 0, 16);
+ }
+ t->wake_up_type = 0x06; /* power switch */
+ SMBIOS_TABLE_SET_STR(1, sku_number_str, type1.sku);
+ SMBIOS_TABLE_SET_STR(1, family_str, type1.family);
+
+ SMBIOS_BUILD_TABLE_POST;
+}
+
static void smbios_build_type_2_table(void)
{
SMBIOS_BUILD_TABLE_PRE(2, 0x200, false); /* optional */
@@ -379,6 +435,9 @@ void smbios_set_defaults(const char *manufacturer,
const char *product, const char *version)
{
smbios_have_defaults = true;
+ SMBIOS_SET_DEFAULT(type0.vendor, manufacturer);
+ SMBIOS_SET_DEFAULT(type0.version, version);
+ SMBIOS_SET_DEFAULT(type0.date, "01/01/2014");
SMBIOS_SET_DEFAULT(type1.manufacturer, manufacturer);
SMBIOS_SET_DEFAULT(type1.product, product);
SMBIOS_SET_DEFAULT(type1.version, version);
@@ -390,9 +449,13 @@ void smbios_set_defaults(const char *manufacturer,
uint8_t *smbios_get_table(size_t *length)
{
if (!smbios_immutable) {
+ smbios_build_type_0_table();
+ smbios_build_type_1_table();
smbios_build_type_2_table();
+if (false) { /* shut up gcc until we remove deprecated code */
smbios_build_type_0_fields();
smbios_build_type_1_fields();
+}
smbios_validate_table();
smbios_immutable = true;
}
--
1.8.5.3
next prev parent reply other threads:[~2014-03-18 23:23 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 23:23 [Qemu-devel] [v4 PATCH 00/12] SMBIOS: build full tables in QEMU Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 01/12] SMBIOS: Rename smbios_set_type1_defaults() for more general use Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 02/12] SMBIOS: Use macro to set smbios defaults Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 03/12] SMBIOS: Use bitmaps to check for smbios table collisions Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 04/12] SMBIOS: Add code to build full smbios tables; build type 2 table Gabriel L. Somlo
2014-03-18 23:23 ` Gabriel L. Somlo [this message]
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 06/12] SMBIOS: Remove unused code for passing individual fields to bios Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 07/12] SMBIOS: Build full type 3 table Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 08/12] SMBIOS: Build full type 4 tables Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 09/12] SMBIOS: Build full smbios memory tables (type 16, 17, 19, and 20) Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 10/12] SMBIOS: Build full tables for type 32 and 127 Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 11/12] SMBIOS: Update all table definitions to smbios spec v2.3 Gabriel L. Somlo
2014-03-18 23:23 ` [Qemu-devel] [v4 PATCH 12/12] SMBIOS: Remove SeaBIOS compatibility quirks Gabriel L. Somlo
2014-03-26 19:58 ` [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU) Gabriel L. Somlo
2014-03-26 22:36 ` Kevin O'Connor
2014-03-31 20:18 ` Gabriel L. Somlo
2014-04-01 8:40 ` Laszlo Ersek
2014-04-01 14:39 ` Kevin O'Connor
2014-04-01 15:47 ` Laszlo Ersek
2014-04-01 18:47 ` Gabriel L. Somlo
2014-04-01 20:28 ` Kevin O'Connor
2014-04-01 21:28 ` Gabriel L. Somlo
2014-04-01 21:44 ` Laszlo Ersek
2014-04-01 22:00 ` Kevin O'Connor
2014-04-01 22:35 ` Laszlo Ersek
2014-04-02 12:38 ` Gabriel L. Somlo
2014-04-02 13:39 ` Laszlo Ersek
2014-04-05 2:48 ` Kevin O'Connor
2014-04-02 15:07 ` Gerd Hoffmann
2014-04-02 17:01 ` Gabriel L. Somlo
2014-04-03 1:57 ` Gabriel L. Somlo
2014-04-03 9:42 ` Laszlo Ersek
2014-04-03 13:32 ` Gabriel L. Somlo
2014-04-03 13:56 ` Laszlo Ersek
2014-04-07 6:50 ` Gerd Hoffmann
2014-04-07 6:47 ` Gerd Hoffmann
2014-04-01 21:48 ` Kevin O'Connor
2014-04-02 15:04 ` Gerd Hoffmann
2014-04-05 0:34 ` Kevin O'Connor
2014-04-05 1:15 ` Gabriel L. Somlo
2014-04-05 2:26 ` Kevin O'Connor
2014-04-07 7:09 ` Gerd Hoffmann
2014-04-07 14:14 ` Kevin O'Connor
2014-04-07 14:33 ` Laszlo Ersek
2014-04-07 14:49 ` Gabriel L. Somlo
2014-04-07 15:23 ` Kevin O'Connor
2014-04-07 18:05 ` Gabriel L. Somlo
2014-04-07 18:57 ` Kevin O'Connor
2014-04-08 13:51 ` Gabriel L. Somlo
2014-03-27 2:45 ` Gabriel L. Somlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395185009-26532-6-git-send-email-somlo@cmu.edu \
--to=gsomlo@gmail.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).