From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, anthony@codemonkey.ws
Subject: [Qemu-devel] [PULL 3/8] qemu-io: Extended "--cmd" description in usage text
Date: Wed, 19 Mar 2014 14:12:02 +0100 [thread overview]
Message-ID: <1395234727-6841-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1395234727-6841-1-git-send-email-kwolf@redhat.com>
From: Maria Kustova <maxa@catit.be>
It's not clear from the usage description that "--cmd" option accepts
its argument as a string, so any special symbols have to be quoted from
the shell.
Updates in usage text:
- Specified parameter format for "--cmd" option.
- Added an instruction how to get help for "--cmd" option.
Signed-off-by: Maria Kustova <maria.k@catit.be>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-io.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 2d119c2..5d7b53f 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -193,10 +193,11 @@ static const cmdinfo_t quit_cmd = {
static void usage(const char *name)
{
printf(
-"Usage: %s [-h] [-V] [-rsnm] [-c cmd] ... [file]\n"
+"Usage: %s [-h] [-V] [-rsnm] [-c STRING] ... [file]\n"
"QEMU Disk exerciser\n"
"\n"
-" -c, --cmd command to execute\n"
+" -c, --cmd STRING execute command with its arguments\n"
+" from the given string\n"
" -r, --read-only export read-only\n"
" -s, --snapshot use snapshot file\n"
" -n, --nocache disable host cache\n"
@@ -207,8 +208,10 @@ static void usage(const char *name)
" -T, --trace FILE enable trace events listed in the given file\n"
" -h, --help display this help and exit\n"
" -V, --version output version information and exit\n"
+"\n"
+"See '%s -c help' for information on available commands."
"\n",
- name);
+ name, name);
}
static char *get_prompt(void)
--
1.8.3.1
next prev parent reply other threads:[~2014-03-19 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 13:11 [Qemu-devel] [PULL 0/8] Block patches for 2.0.0-rc1 Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 1/8] block: Add error handling to bdrv_invalidate_cache() Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 2/8] qemu-io-cmds: Fixed typo in example for writev Kevin Wolf
2014-03-19 13:12 ` Kevin Wolf [this message]
2014-03-19 13:12 ` [Qemu-devel] [PULL 4/8] qcow2: Correct comment for realloc_refcount_block() Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 5/8] qcow2: Fix fail path in realloc_refcount_block() Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 6/8] block/nfs: bump libnfs requirement to 1.9.3 Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 7/8] block/nfs: report errors from libnfs Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 8/8] dataplane: fix implicit IOThread refcount Kevin Wolf
2014-03-19 14:16 ` [Qemu-devel] [PULL 0/8] Block patches for 2.0.0-rc1 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395234727-6841-4-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).