From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, anthony@codemonkey.ws
Subject: [Qemu-devel] [PULL 4/8] qcow2: Correct comment for realloc_refcount_block()
Date: Wed, 19 Mar 2014 14:12:03 +0100 [thread overview]
Message-ID: <1395234727-6841-5-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1395234727-6841-1-git-send-email-kwolf@redhat.com>
From: Max Reitz <mreitz@redhat.com>
Contrary to the comment describing this function's behavior, it does not
return 0 on success, but rather the offset of the newly allocated
cluster. This patch adjusts the comment accordingly to reflect the
actual behavior.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2-refcount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 6151148..3f2ed08 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -1383,7 +1383,7 @@ static int write_reftable_entry(BlockDriverState *bs, int rt_index)
* does _not_ decrement the reference count for the currently occupied cluster.
*
* This function prints an informative message to stderr on error (and returns
- * -errno); on success, 0 is returned.
+ * -errno); on success, the offset of the newly allocated cluster is returned.
*/
static int64_t realloc_refcount_block(BlockDriverState *bs, int reftable_index,
uint64_t offset)
--
1.8.3.1
next prev parent reply other threads:[~2014-03-19 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 13:11 [Qemu-devel] [PULL 0/8] Block patches for 2.0.0-rc1 Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 1/8] block: Add error handling to bdrv_invalidate_cache() Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 2/8] qemu-io-cmds: Fixed typo in example for writev Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 3/8] qemu-io: Extended "--cmd" description in usage text Kevin Wolf
2014-03-19 13:12 ` Kevin Wolf [this message]
2014-03-19 13:12 ` [Qemu-devel] [PULL 5/8] qcow2: Fix fail path in realloc_refcount_block() Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 6/8] block/nfs: bump libnfs requirement to 1.9.3 Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 7/8] block/nfs: report errors from libnfs Kevin Wolf
2014-03-19 13:12 ` [Qemu-devel] [PULL 8/8] dataplane: fix implicit IOThread refcount Kevin Wolf
2014-03-19 14:16 ` [Qemu-devel] [PULL 0/8] Block patches for 2.0.0-rc1 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395234727-6841-5-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).