From: Marcel Apfelbaum <marcel.a@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] acpi: fix endian-ness for table ids
Date: Wed, 19 Mar 2014 15:49:57 +0200 [thread overview]
Message-ID: <1395236997.6667.5.camel@localhost.localdomain> (raw)
In-Reply-To: <53288B62.3060200@redhat.com>
On Tue, 2014-03-18 at 19:07 +0100, Laszlo Ersek wrote:
> On 03/18/14 15:48, Michael S. Tsirkin wrote:
> > when using signature for table ID, we forgot to byte-swap it.
> > signatures are really ASCII strings, let's treat them as such.
> > While at it, get rid of most of _SIGNATURE macros.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/i386/acpi-defs.h | 14 --------------
> > hw/i386/acpi-build.c | 31 ++++++++++++++++---------------
> > 2 files changed, 16 insertions(+), 29 deletions(-)
>
> Looks reasonable. Of course you'll probably want Marcel's R-b.
I agree with the changes, but sadly it does not resolve the problem for ppc64 hosts.
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2014-03-19 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 14:48 [Qemu-devel] [PATCH 1/2] acpi-test: signature endian-ness fixes Michael S. Tsirkin
2014-03-18 14:48 ` [Qemu-devel] [PATCH 2/2] acpi: fix endian-ness for table ids Michael S. Tsirkin
2014-03-18 18:07 ` Laszlo Ersek
2014-03-19 13:49 ` Marcel Apfelbaum [this message]
2014-03-18 18:02 ` [Qemu-devel] [PATCH 1/2] acpi-test: signature endian-ness fixes Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395236997.6667.5.camel@localhost.localdomain \
--to=marcel.a@redhat.com \
--cc=aliguori@amazon.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).