From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQGsI-0001Rz-V9 for qemu-devel@nongnu.org; Wed, 19 Mar 2014 09:49:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQGsC-0000ZA-Gr for qemu-devel@nongnu.org; Wed, 19 Mar 2014 09:49:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQGsC-0000YK-9R for qemu-devel@nongnu.org; Wed, 19 Mar 2014 09:49:36 -0400 Message-ID: <1395236997.6667.5.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Wed, 19 Mar 2014 15:49:57 +0200 In-Reply-To: <53288B62.3060200@redhat.com> References: <1395154048-28278-1-git-send-email-mst@redhat.com> <1395154048-28278-2-git-send-email-mst@redhat.com> <53288B62.3060200@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] acpi: fix endian-ness for table ids List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" On Tue, 2014-03-18 at 19:07 +0100, Laszlo Ersek wrote: > On 03/18/14 15:48, Michael S. Tsirkin wrote: > > when using signature for table ID, we forgot to byte-swap it. > > signatures are really ASCII strings, let's treat them as such. > > While at it, get rid of most of _SIGNATURE macros. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/i386/acpi-defs.h | 14 -------------- > > hw/i386/acpi-build.c | 31 ++++++++++++++++--------------- > > 2 files changed, 16 insertions(+), 29 deletions(-) > > Looks reasonable. Of course you'll probably want Marcel's R-b. I agree with the changes, but sadly it does not resolve the problem for ppc64 hosts. Reviewed-by: Marcel Apfelbaum > > Reviewed-by: Laszlo Ersek