qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: arei.gonglei@huawei.com, armbru@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock
Date: Wed, 19 Mar 2014 18:32:29 +0000	[thread overview]
Message-ID: <1395253951-14524-1-git-send-email-dgilbert@redhat.com> (raw)

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Markus Armbruster spotted that the XBZRLE.lock might get initalised
multiple times in the case of a second attempted migration, and
that's undefined behaviour for pthread_mutex_init.

This patchset is based on Markus' proto-patch in the discussions
off v1.

--
v2
   Rework completely based on Markus's patch

Dr. David Alan Gilbert (2):
  Provide init function for ram migration
  Init the XBZRLE.lock in ram_mig_init

 arch_init.c                   | 68 +++++++++++++++++++++++--------------------
 include/migration/migration.h |  2 --
 include/sysemu/arch_init.h    |  1 +
 vl.c                          |  3 +-
 4 files changed, 39 insertions(+), 35 deletions(-)

-- 
1.8.5.3

             reply	other threads:[~2014-03-19 18:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 18:32 Dr. David Alan Gilbert (git) [this message]
2014-03-19 18:32 ` [Qemu-devel] [PATCH v2 1/2] Provide init function for ram migration Dr. David Alan Gilbert (git)
2014-03-20 12:42   ` Gonglei (Arei)
2014-03-19 18:32 ` [Qemu-devel] [PATCH v2 2/2] Init the XBZRLE.lock in ram_mig_init Dr. David Alan Gilbert (git)
2014-03-20 12:43   ` Gonglei (Arei)
2014-03-20  7:18 ` [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock Markus Armbruster
2014-03-20 12:56   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395253951-14524-1-git-send-email-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).