qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>,
	"Anthony Liguori" <aliguori@amazon.com>,
	"Marcel Apfelbaum" <marcel.a@redhat.com>
Subject: [Qemu-devel] [PULL for-2.0 2/7] vl.c: Fix OpenBSD compilation issue due to namespace collisions
Date: Wed, 19 Mar 2014 22:45:37 +0100	[thread overview]
Message-ID: <1395265542-384-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1395265542-384-1-git-send-email-afaerber@suse.de>

From: Marcel Apfelbaum <marcel.a@redhat.com>

Machine rewriting added MACHINE() macro which is
already in use by other OpenBSD library.
Since qemu/sockets.h exposes the OpenBSD namespace,
the minimalistic approach is to add it as the first QEMU include.

Reported-by: Brad Smith <brad@comstyle.com>
Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 include/hw/boards.h | 1 +
 vl.c                | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/hw/boards.h b/include/hw/boards.h
index 7bd2ea7..dd2c70d 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -54,6 +54,7 @@ struct QEMUMachine {
 int qemu_register_machine(QEMUMachine *m);
 
 #define TYPE_MACHINE "machine"
+#undef MACHINE  /* BSD defines it and QEMU does not use it */
 #define MACHINE(obj) \
     OBJECT_CHECK(MachineState, (obj), TYPE_MACHINE)
 #define MACHINE_GET_CLASS(obj) \
diff --git a/vl.c b/vl.c
index 0e82f06..e2e2ac7 100644
--- a/vl.c
+++ b/vl.c
@@ -58,6 +58,7 @@ int main(int argc, char **argv)
 
 #include <glib.h>
 
+#include "qemu/sockets.h"
 #include "hw/hw.h"
 #include "hw/boards.h"
 #include "hw/usb.h"
@@ -103,7 +104,6 @@ int main(int argc, char **argv)
 
 #include "disas/disas.h"
 
-#include "qemu/sockets.h"
 
 #include "slirp/libslirp.h"
 
-- 
1.8.4.5

  parent reply	other threads:[~2014-03-19 21:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 21:45 [Qemu-devel] [PULL for-2.0-rc1 0/7] QOM devices patch queue 2014-03-19 Andreas Färber
2014-03-19 21:45 ` [Qemu-devel] [PULL for-2.0 1/7] vl.c: Fix memory leak in qemu_register_machine() Andreas Färber
2014-03-19 21:45 ` Andreas Färber [this message]
2014-03-19 21:45 ` [Qemu-devel] [PULL for-2.0 3/7] qom: Split object_property_set_link() Andreas Färber
2014-03-19 21:45 ` [Qemu-devel] [PULL for-2.0 4/7] qom: Don't make link NULL on object_property_set_link() failure Andreas Färber
2014-03-19 21:45 ` [Qemu-devel] [PULL for-2.0 5/7] qom: Make QOM link property unref optional Andreas Färber
2014-03-19 21:45 ` [Qemu-devel] [PULL for-2.0 6/7] qom: Add check() argument to object_property_add_link() Andreas Färber
2014-03-19 21:45 ` [Qemu-devel] [PULL for-2.0 7/7] virtio-rng: Avoid default_backend refcount leak Andreas Färber
2014-03-19 22:38 ` [Qemu-devel] [PULL for-2.0-rc1 0/7] QOM devices patch queue 2014-03-19 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395265542-384-3-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=marcel.a@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).