[Qemu-devel] [PULL for-2.0-rc1 0/1] QOM CPUState patch queue 2014-03-19 #2

[Qemu-devel] [PULL for-2.0-rc1 0/1] QOM CPUState patch queue 2014-03-19 #2

[Andreas Färber]

Hello Peter,

This is my current QOM CPU patch queue. Please pull.

Regards,
Andreas

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <anthony@codemonkey.ws>

The following changes since commit f71e769d0754dc9a593a9e17ec6693a261b29f82:

  Merge remote-tracking branch 'remotes/afaerber/tags/qom-cpu-for-2.0' into staging (2014-03-19 19:05:13 +0000)

are available in the git repository at:


  git://github.com/afaerber/qemu-cpu.git tags/qom-cpu-for-2.0

for you to fetch changes up to 7e4fb26d757b460de5b80b4220bcd926f7175cb2:

  cpu: Move tcg_exit_req to the end of CPUState (2014-03-19 22:11:19 +0100)

----------------------------------------------------------------
QOM CPUState refactorings / X86CPU

* CPUState layout optimization for TCG

----------------------------------------------------------------
Richard Henderson (1):
      cpu: Move tcg_exit_req to the end of CPUState

 include/qom/cpu.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL for-2.0 1/1] cpu: Move tcg_exit_req to the end of CPUState

[Andreas Färber]

From: Richard Henderson <rth@twiddle.net>

Reverse an increase in the size of generated code.

Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 include/qom/cpu.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 06ee263..f99885a 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -227,7 +227,6 @@ struct CPUState {
     bool stop;
     bool stopped;
     volatile sig_atomic_t exit_request;
-    volatile sig_atomic_t tcg_exit_req;
     uint32_t interrupt_request;
     int singlestep_enabled;
     int64_t icount_extra;
@@ -272,6 +271,12 @@ struct CPUState {
     } icount_decr;
     uint32_t can_do_io;
     int32_t exception_index; /* used by m68k TCG */
+
+    /* Note that this is accessed at the start of every TB via a negative
+       offset from AREG0.  Leave this field at the end so as to make the
+       (absolute value) offset as small as possible.  This reduces code
+       size, especially for hosts without large memory offsets.  */
+    volatile sig_atomic_t tcg_exit_req;
 };
 
 QTAILQ_HEAD(CPUTailQ, CPUState);
-- 
1.8.4.5

Re: [Qemu-devel] [PULL for-2.0-rc1 0/1] QOM CPUState patch queue 2014-03-19 #2

[Peter Maydell]

On 19 March 2014 21:53, Andreas Färber <afaerber@suse.de> wrote:
> Hello Peter,
>
> This is my current QOM CPU patch queue. Please pull.
>
> Regards,
> Andreas
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Anthony Liguori <anthony@codemonkey.ws>
>
> The following changes since commit f71e769d0754dc9a593a9e17ec6693a261b29f82:
>
>   Merge remote-tracking branch 'remotes/afaerber/tags/qom-cpu-for-2.0' into staging (2014-03-19 19:05:13 +0000)
>
> are available in the git repository at:
>
>
>   git://github.com/afaerber/qemu-cpu.git tags/qom-cpu-for-2.0
>
> for you to fetch changes up to 7e4fb26d757b460de5b80b4220bcd926f7175cb2:
>
>   cpu: Move tcg_exit_req to the end of CPUState (2014-03-19 22:11:19 +0100)

Applied, thanks.

-- PMM