From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQS6a-0000aN-5t for qemu-devel@nongnu.org; Wed, 19 Mar 2014 21:49:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQS6O-0003xe-3K for qemu-devel@nongnu.org; Wed, 19 Mar 2014 21:49:12 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 20 Mar 2014 02:48:43 +0100 Message-Id: <1395280135-10644-2-git-send-email-afaerber@suse.de> In-Reply-To: <1395280135-10644-1-git-send-email-afaerber@suse.de> References: <1395280135-10644-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL for-2.0 01/13] target-ppc: Add missing 'static' and 'const' attributes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Weil , qemu-ppc@nongnu.org, =?UTF-8?q?Andreas=20F=C3=A4rber?= , Alexander Graf From: Stefan Weil This fixes warnings from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Andreas F=C3=A4rber --- target-ppc/arch_dump.c | 6 +++--- target-ppc/int_helper.c | 2 +- target-ppc/machine.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target-ppc/arch_dump.c b/target-ppc/arch_dump.c index 17fd4c6..9dccf1a 100644 --- a/target-ppc/arch_dump.c +++ b/target-ppc/arch_dump.c @@ -164,7 +164,7 @@ static void ppc64_write_elf64_speregset(Note *note, P= owerPCCPU *cpu) speregset->spe_fscr =3D cpu_to_be32(cpu->env.spe_fscr); } =20 -struct NoteFuncDescStruct { +static const struct NoteFuncDescStruct { int contents_size; void (*note_contents_func)(Note *note, PowerPCCPU *cpu); } note_func[] =3D { @@ -196,7 +196,7 @@ ssize_t cpu_get_note_size(int class, int machine, int= nr_cpus) int name_size =3D 8; /* "CORE" or "QEMU" rounded */ size_t elf_note_size =3D 0; int note_head_size; - NoteFuncDesc *nf; + const NoteFuncDesc *nf; =20 if (class !=3D ELFCLASS64) { return -1; @@ -221,7 +221,7 @@ static int ppc64_write_all_elf64_notes(const char *no= te_name, Note note; int ret =3D -1; int note_size; - NoteFuncDesc *nf; + const NoteFuncDesc *nf; =20 for (nf =3D note_func; nf->note_contents_func; nf++) { note.hdr.n_namesz =3D cpu_to_be32(sizeof(note.name)); diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c index e14e304..18b54f0 100644 --- a/target-ppc/int_helper.c +++ b/target-ppc/int_helper.c @@ -1075,7 +1075,7 @@ void helper_vbpermq(ppc_avr_t *r, ppc_avr_t *a, ppc= _avr_t *b) #undef VBPERMQ_INDEX #undef VBPERMQ_DW =20 -uint64_t VGBBD_MASKS[256] =3D { +static const uint64_t VGBBD_MASKS[256] =3D { 0x0000000000000000ull, /* 00 */ 0x0000000000000080ull, /* 01 */ 0x0000000000008000ull, /* 02 */ diff --git a/target-ppc/machine.c b/target-ppc/machine.c index 2d46cec..063b379 100644 --- a/target-ppc/machine.c +++ b/target-ppc/machine.c @@ -114,7 +114,7 @@ static void put_avr(QEMUFile *f, void *pv, size_t siz= e) qemu_put_be64(f, v->u64[1]); } =20 -const VMStateInfo vmstate_info_avr =3D { +static const VMStateInfo vmstate_info_avr =3D { .name =3D "avr", .get =3D get_avr, .put =3D put_avr, @@ -288,7 +288,7 @@ static void put_slbe(QEMUFile *f, void *pv, size_t si= ze) qemu_put_be64(f, v->vsid); } =20 -const VMStateInfo vmstate_info_slbe =3D { +static const VMStateInfo vmstate_info_slbe =3D { .name =3D "slbe", .get =3D get_slbe, .put =3D put_slbe, --=20 1.8.4.5