From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Stuart Brady" <sdb@zubnet.me.uk>,
qemu-ppc@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
"Alexander Graf" <agraf@suse.de>
Subject: [Qemu-devel] [PULL for-2.0 04/13] target-ppc: Fix overallocation of opcode tables
Date: Thu, 20 Mar 2014 02:48:46 +0100 [thread overview]
Message-ID: <1395280135-10644-5-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1395280135-10644-1-git-send-email-afaerber@suse.de>
From: Stuart Brady <sdb@zubnet.me.uk>
create_new_table() should allocate 0x20 opc_handler_t pointers, but
actually allocates 0x20 opc_handler_t structs. Fix this.
Signed-off-by: Stuart Brady <sdb@zubnet.me.uk>
Reviewed-by: Tom Musta <tommusta@gmail.com>
Tested-by: Tom Musta <tommusta@gmail.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
target-ppc/translate_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 954dee3..3269c3e 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -7434,7 +7434,7 @@ static int create_new_table (opc_handler_t **table, unsigned char idx)
{
opc_handler_t **tmp;
- tmp = g_malloc(0x20 * sizeof(opc_handler_t));
+ tmp = g_new(opc_handler_t *, 0x20);
fill_new_table(tmp, 0x20);
table[idx] = (opc_handler_t *)((uintptr_t)tmp | PPC_INDIRECT);
--
1.8.4.5
next prev parent reply other threads:[~2014-03-20 1:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 1:48 [Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2 Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 01/13] target-ppc: Add missing 'static' and 'const' attributes Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 02/13] spapr_hcall: Fix h_enter to loop correctly Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 03/13] target-ppc: Reset SPRs on CPU reset Andreas Färber
2014-03-20 1:48 ` Andreas Färber [this message]
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 05/13] target-ppc: Force CPU threads count to be a power of 2 Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 06/13] target-ppc: Introduce powerisa-207-server flag Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 07/13] spapr_hcall: Fix little-endian resource handling in H_SET_MODE Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 08/13] vl.c: Extend get_boot_devices_list() to ignore suffixes Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 09/13] qdev: Introduce FWPathProvider interface Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 10/13] spapr_llan: Add to boot device list Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 11/13] spapr_vio: Fix firmware names Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 12/13] spapr: QOM'ify pseries machine Andreas Färber
2014-03-20 1:48 ` [Qemu-devel] [PULL for-2.0 13/13] spapr: Implement interface to fix device pathname Andreas Färber
2014-03-20 12:17 ` [Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395280135-10644-5-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sdb@zubnet.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).