From: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Igor Mammedov" <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu()
Date: Thu, 20 Mar 2014 14:25:13 +0800 [thread overview]
Message-ID: <1395296713.12213.36.camel@G08FNSTD131468> (raw)
In-Reply-To: <20140319192720.GB10819@otherpad.lan.raisama.net>
On Wed, 2014-03-19 at 16:27 -0300, Eduardo Habkost wrote:
> On Wed, Mar 19, 2014 at 04:53:41PM +0800, Chen Fan wrote:
> > introduce x86_cpu_topo_ids_from_index() to calculate the cpu topology
> > information, and the compat old mode mechanism moved into there.
> > remove unused funciton x86_apicid_from_cpu_idx().
> >
> > Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> [...]
> > -static inline apic_id_t x86_apicid_from_cpu_idx(unsigned nr_cores,
> > - unsigned nr_threads,
> > - unsigned cpu_index)
> > +static inline void x86_topo_ids_from_apic_id(unsigned nr_cores,
> > + unsigned nr_threads,
> > + apic_id_t apic_id,
> > + X86CPUTopoInfo *topo)
>
> You need to squash this patch and patch 3/4 together, otherwise we get
> unit test failures in the intermediate tree.
Ok, this patches will come soon.
Thanks
>
> Otherwise, patch looks good.
>
next prev parent reply other threads:[~2014-03-20 6:32 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 9:27 [Qemu-devel] [RFC 0/3] fix migration issues after hotplug a discontinuous cpuid Chen Fan
2014-01-14 9:27 ` [Qemu-devel] [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn() Chen Fan
2014-01-14 10:40 ` Igor Mammedov
2014-01-15 12:24 ` Chen Fan
2014-01-15 14:37 ` Igor Mammedov
2014-01-17 19:13 ` [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn()) Eduardo Habkost
2014-01-20 12:29 ` Igor Mammedov
2014-01-21 7:12 ` Chen Fan
2014-01-21 9:31 ` Igor Mammedov
2014-01-21 9:51 ` Chen Fan
2014-01-21 10:10 ` Andreas Färber
2014-02-13 6:14 ` Chen Fan
2014-02-13 9:44 ` Igor Mammedov
2014-02-17 10:24 ` Chen Fan
2014-02-17 10:43 ` Igor Mammedov
2014-02-25 9:07 ` [Qemu-devel] [PATCH 0/2][RFC] prebuild cpu QOM tree /machine/node/socket/core/thread/ Chen Fan
2014-02-25 9:07 ` [Qemu-devel] [PATCH 1/2][RFC] qom: introduce cpu QOM hierarchy tree /machine/node/socket/core/thread/cpu Chen Fan
2014-02-25 13:35 ` Eric Blake
2014-02-26 1:05 ` Chen Fan
2014-02-26 18:52 ` Eduardo Habkost
2014-02-28 2:01 ` Chen Fan
2014-03-04 10:50 ` [Qemu-devel] [RFC v2 0/2] prebuild cpu QOM tree /machine/node/socket/core/thread/ Chen Fan
2014-03-04 10:50 ` [Qemu-devel] [RFC v2 1/2] i386: introduce "struct X86TopoInfo" for saving cpu topology information Chen Fan
2014-03-04 19:35 ` Eduardo Habkost
2014-03-05 1:33 ` Chen Fan
2014-03-11 10:58 ` [Qemu-devel] [RFC v3 0/3] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu chen.fan.fnst
2014-03-11 10:58 ` [Qemu-devel] [RFC v3 1/3] cpu: introduce CpuTopoInfo structure for argument simplification chen.fan.fnst
2014-03-11 17:10 ` Eduardo Habkost
2014-03-11 10:58 ` [Qemu-devel] [RFC v3 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu() chen.fan.fnst
2014-03-11 18:00 ` Eduardo Habkost
2014-03-12 5:53 ` Chen Fan
2014-03-12 7:51 ` [Qemu-devel] [RFC v4 0/3] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu Chen Fan
2014-03-12 7:51 ` [Qemu-devel] [RFC v4 1/3] cpu: introduce CpuTopoInfo structure for argument simplification Chen Fan
2014-03-12 15:36 ` Eduardo Habkost
2014-03-19 8:53 ` [Qemu-devel] [PATCH v1 0/4] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu Chen Fan
2014-03-19 8:53 ` [Qemu-devel] [PATCH v1 1/4] cpu: introduce CpuTopoInfo structure for argument simplification Chen Fan
2014-03-19 8:53 ` [Qemu-devel] [PATCH v1 2/4] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu() Chen Fan
2014-03-19 19:27 ` Eduardo Habkost
2014-03-20 6:25 ` Chen Fan [this message]
2014-03-19 8:53 ` [Qemu-devel] [PATCH v1 3/4] topo unit-test: update Unit tests to test-x86-cpuid.c Chen Fan
2014-03-19 8:53 ` [Qemu-devel] [PATCH v1 4/4] i386: introduce cpu QOM hierarchy tree Chen Fan
2014-03-19 12:00 ` [Qemu-devel] [PATCH v1 0/4] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu Eric Blake
2014-03-20 0:55 ` Chen Fan
2014-03-12 7:51 ` [Qemu-devel] [RFC v4 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu() Chen Fan
2014-03-12 15:39 ` Eduardo Habkost
2014-03-12 7:51 ` [Qemu-devel] [RFC v4 3/3] i386: introduce cpu QOM hierarchy tree Chen Fan
2014-03-11 10:58 ` [Qemu-devel] [RFC v3 " chen.fan.fnst
2014-03-04 10:50 ` [Qemu-devel] [RFC v2 2/2] " Chen Fan
2014-02-25 9:07 ` [Qemu-devel] [PATCH 2/2][RFC] cpu: link each new cpu to QOM tree /machine/node/socket/core/thread/cpu respectively Chen Fan
2014-02-26 19:11 ` Eduardo Habkost
2014-02-13 10:00 ` [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn()) Igor Mammedov
2014-01-14 9:27 ` [Qemu-devel] [RFC 2/3] target-i386: add -smp X,apics=0x option Chen Fan
2014-02-17 18:37 ` Eric Blake
2014-02-18 1:49 ` Chen Fan
2014-01-14 9:27 ` [Qemu-devel] [RFC 3/3] target-i386: add qmp command 'query-cpus' to display apic_id Chen Fan
2014-02-17 18:37 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395296713.12213.36.camel@G08FNSTD131468 \
--to=chen.fan.fnst@cn.fujitsu.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).