From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel.a@redhat.com, mst@redhat.com,
vasilis.liaskovitis@profitbricks.com, aliguori@amazon.com,
pbonzini@redhat.com, afaerber@suse.de
Subject: [Qemu-devel] [RFC 4/8] qdev: link based hotplug
Date: Thu, 20 Mar 2014 16:01:12 +0100 [thread overview]
Message-ID: <1395327676-29753-5-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1395327676-29753-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/core/hotplug.c | 30 ++++++++++++++++++++++++++++++
hw/core/qdev.c | 15 +++++++++++++++
include/hw/hotplug.h | 2 ++
include/hw/qdev-core.h | 6 ++++++
4 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/hw/core/hotplug.c b/hw/core/hotplug.c
index 5573d9d..1a13ca3 100644
--- a/hw/core/hotplug.c
+++ b/hw/core/hotplug.c
@@ -11,6 +11,36 @@
*/
#include "hw/hotplug.h"
#include "qemu/module.h"
+#include <string.h>
+
+HotplugHandler *hotplug_handler_get_from_path(const char *path)
+{
+ Object *obj;
+ const char *sep;
+ bool ambiguous = false;
+ HotplugHandler *hh = NULL;
+ char *current_path = g_strdup(path);
+
+ while ((sep = strrchr(current_path, '/'))) {
+ char *old_path = current_path;
+ if (!sep || sep == current_path) {
+ break;
+ }
+
+ current_path = g_strndup(current_path, sep - current_path);
+ g_free(old_path);
+
+ obj = object_resolve_path(current_path, &ambiguous);
+ g_assert(!ambiguous);
+ hh = (HotplugHandler *)object_dynamic_cast(obj, TYPE_HOTPLUG_HANDLER);
+ if (hh != NULL) {
+ break;
+ }
+ }
+
+ g_free(current_path);
+ return hh;
+}
void hotplug_handler_plug(HotplugHandler *plug_handler,
DeviceState *plugged_dev,
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 9f0a522..a8d6eea 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -743,6 +743,21 @@ static void device_set_realized(Object *obj, bool value, Error **err)
local_err == NULL) {
hotplug_handler_plug(dev->parent_bus->hotplug_handler,
dev, &local_err);
+ } else if (dc->hotplug_path != NULL && local_err == NULL) {
+ HotplugHandler *hotplug_ctrl;
+ char *target_name;
+ char *path = dc->hotplug_path(dev);
+
+ hotplug_ctrl = hotplug_handler_get_from_path(path);
+ g_assert(hotplug_ctrl);
+
+ target_name = g_strdup(strrchr(path, '/') + 1);
+ object_property_set_link(OBJECT(hotplug_ctrl), OBJECT(dev),
+ target_name, &local_err);
+ g_free(target_name);
+ g_free(path);
+
+ hotplug_handler_plug(hotplug_ctrl, dev, &local_err);
}
if (qdev_get_vmsd(dev) && local_err == NULL) {
diff --git a/include/hw/hotplug.h b/include/hw/hotplug.h
index a6533cb..7a3815e 100644
--- a/include/hw/hotplug.h
+++ b/include/hw/hotplug.h
@@ -75,4 +75,6 @@ void hotplug_handler_plug(HotplugHandler *plug_handler,
void hotplug_handler_unplug(HotplugHandler *plug_handler,
DeviceState *plugged_dev,
Error **errp);
+
+HotplugHandler *hotplug_handler_get_from_path(const char *path);
#endif
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index dbe473c..6cd936d 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -116,6 +116,12 @@ typedef struct DeviceClass {
bool cannot_instantiate_with_device_add_yet;
bool hotpluggable;
+ /*
+ * Returns path to link<> that should be set/unset on dev hotplug.
+ * Used for link based bussless devices hotplug.
+ */
+ char* (*hotplug_path)(DeviceState *dev);
+
/* callbacks */
void (*reset)(DeviceState *dev);
DeviceRealize realize;
--
1.7.1
next prev parent reply other threads:[~2014-03-20 15:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 15:01 [Qemu-devel] [RFC 0/8] bus-less device hotplug Igor Mammedov
2014-03-20 15:01 ` [Qemu-devel] [RFC 1/8] vl.c: extend -m option to support options for memory hotplug Igor Mammedov
2014-03-20 15:01 ` [Qemu-devel] [RFC 2/8] make machine_class_init() accessible outside of vl.c Igor Mammedov
2014-03-23 15:27 ` Marcel Apfelbaum
2014-03-23 16:22 ` Marcel Apfelbaum
2014-03-20 15:01 ` [Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state Igor Mammedov
2014-03-23 15:13 ` Marcel Apfelbaum
2014-03-24 10:34 ` Igor Mammedov
2014-03-24 12:28 ` Marcel Apfelbaum
2014-03-24 10:52 ` Andreas Färber
2014-03-24 11:20 ` Michael S. Tsirkin
2014-03-24 11:57 ` Andreas Färber
2014-03-24 12:13 ` Marcel Apfelbaum
2014-03-20 15:01 ` Igor Mammedov [this message]
2014-03-20 16:12 ` [Qemu-devel] [RFC 4/8] qdev: link based hotplug Paolo Bonzini
2014-03-20 16:20 ` Igor Mammedov
2014-03-20 18:03 ` Paolo Bonzini
2014-03-21 10:35 ` Igor Mammedov
2014-03-21 11:45 ` Paolo Bonzini
2014-03-24 9:10 ` Igor Mammedov
2014-03-24 12:20 ` Andreas Färber
2014-03-24 13:12 ` Michael S. Tsirkin
2014-03-20 15:01 ` [Qemu-devel] [RFC 5/8] dimm: implement dimm device abstraction Igor Mammedov
2014-03-20 15:01 ` [Qemu-devel] [RFC 6/8] pc: preallocate hotplug links for DIMMDevices Igor Mammedov
2014-03-20 15:01 ` [Qemu-devel] [RFC 7/8] pc: initialize memory hotplug address space Igor Mammedov
2014-03-20 15:01 ` [Qemu-devel] [RFC 8/8] pc: make PC_MACHINE memory hotplug controller Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395327676-29753-5-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vasilis.liaskovitis@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).