From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQhsg-0001Sh-TI for qemu-devel@nongnu.org; Thu, 20 Mar 2014 14:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQhsa-0005x1-T7 for qemu-devel@nongnu.org; Thu, 20 Mar 2014 14:39:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQhsa-0005wT-LU for qemu-devel@nongnu.org; Thu, 20 Mar 2014 14:39:48 -0400 From: Marcel Apfelbaum Date: Thu, 20 Mar 2014 20:40:08 +0200 Message-Id: <1395340808-21352-1-git-send-email-marcel.a@redhat.com> Subject: [Qemu-devel] [PATCH for-2.0 V2] tests/acpi-test: do not run iasl on big endian machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aik@ozlabs.ru, afaerber@suse.de, mst@redhat.com There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. Do not run iasl on those machines until this problem is solved by the acpica community. Signed-off-by: Marcel Apfelbaum --- V1 -> V2: Addressed an offline tip for a much cleaner macro line, thanks! tests/acpi-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 249fe03..88e876f 100644 --- a/tests/acpi-test.c +++ b/tests/acpi-test.c @@ -145,7 +145,7 @@ static uint8_t boot_sector[0x7e000] = { static const char *disk = "tests/acpi-test-disk.raw"; static const char *data_dir = "tests/acpi-test-data"; -#ifdef CONFIG_IASL +#if G_BYTE_ORDER == G_LITTLE_ENDIAN && defined(CONFIG_IASL) static const char *iasl = stringify(CONFIG_IASL); #else static const char *iasl; -- 1.8.3.1