* [Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines @ 2014-03-20 17:47 Marcel Apfelbaum 2014-03-20 19:00 ` Peter Maydell 0 siblings, 1 reply; 3+ messages in thread From: Marcel Apfelbaum @ 2014-03-20 17:47 UTC (permalink / raw) To: qemu-devel; +Cc: aik, mst There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables. Do not run iasl on those machines until this problem is solved by the acpica community. Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com> --- tests/acpi-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 249fe03..af44e47 100644 --- a/tests/acpi-test.c +++ b/tests/acpi-test.c @@ -145,8 +145,10 @@ static uint8_t boot_sector[0x7e000] = { static const char *disk = "tests/acpi-test-disk.raw"; static const char *data_dir = "tests/acpi-test-data"; +#if G_BYTE_ORDER == G_LITTLE_ENDIAN #ifdef CONFIG_IASL static const char *iasl = stringify(CONFIG_IASL); +#endif #else static const char *iasl; #endif -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines 2014-03-20 17:47 [Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines Marcel Apfelbaum @ 2014-03-20 19:00 ` Peter Maydell 2014-03-20 19:08 ` Marcel Apfelbaum 0 siblings, 1 reply; 3+ messages in thread From: Peter Maydell @ 2014-03-20 19:00 UTC (permalink / raw) To: Marcel Apfelbaum Cc: Alexey Kardashevskiy, QEMU Developers, Michael S. Tsirkin On 20 March 2014 17:47, Marcel Apfelbaum <marcel.a@redhat.com> wrote: > There is an issue with iasl on big endian machines: It > cannot disassemble acpi tables taken from little endian > machines, so we cannot check the expected tables. > > Do not run iasl on those machines until this > problem is solved by the acpica community. Is there an upstream bug report for this? It would be nice to have a reference somewhere so we can tell if we can remove the check in future... thanks -- PMM ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines 2014-03-20 19:00 ` Peter Maydell @ 2014-03-20 19:08 ` Marcel Apfelbaum 0 siblings, 0 replies; 3+ messages in thread From: Marcel Apfelbaum @ 2014-03-20 19:08 UTC (permalink / raw) To: Peter Maydell; +Cc: Alexey Kardashevskiy, QEMU Developers, Michael S. Tsirkin On Thu, 2014-03-20 at 19:00 +0000, Peter Maydell wrote: > On 20 March 2014 17:47, Marcel Apfelbaum <marcel.a@redhat.com> wrote: > > There is an issue with iasl on big endian machines: It > > cannot disassemble acpi tables taken from little endian > > machines, so we cannot check the expected tables. > > > > Do not run iasl on those machines until this > > problem is solved by the acpica community. > > Is there an upstream bug report for this? It would be > nice to have a reference somewhere so we can tell if > we can remove the check in future... Hi Peter, I opened a bug http://bugs.acpica.org/show_bug.cgi?id=1082 and started a discussion https://lists.acpica.org/pipermail/devel/2014-March/000637.html Thanks, Marcel > > thanks > -- PMM > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-20 19:08 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-03-20 17:47 [Qemu-devel] [PATCH for-2.0] tests/acpi-test: do not run iasl on big endian machines Marcel Apfelbaum 2014-03-20 19:00 ` Peter Maydell 2014-03-20 19:08 ` Marcel Apfelbaum
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).