From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com, aik@ozlabs.ru,
mjt@tls.msk.ru, stefanha@redhat.com, pbonzini@redhat.com,
afaerber@suse.de, rth@twiddle.net
Subject: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines
Date: Thu, 20 Mar 2014 23:14:59 +0200 [thread overview]
Message-ID: <1395350099-14664-1-git-send-email-marcel.a@redhat.com> (raw)
There is an issue with iasl on big endian machines: It
cannot disassemble acpi tables taken from little endian
machines, so we cannot check the expected tables.
Do not run iasl on those machines until this
problem is solved by the acpica community.
Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
---
V2 -> V3:
Addressed Michael S. Tsirkin's review:
- tests don't need to re-run detection, use configure
to figure out if it is an LE machine.
V1 -> V2:
Addressed an offline tip for a much cleaner
macro line, thanks!
configure | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index aae617e..2c0a3b2 100755
--- a/configure
+++ b/configure
@@ -4656,7 +4656,10 @@ else
fi
echo "PYTHON=$python" >> $config_host_mak
echo "CC=$cc" >> $config_host_mak
-if $iasl -h > /dev/null 2>&1; then
+# All known versions of iasl on BE machines are broken.
+# TODO: add detection code once a non-broken version makes an appearance.
+if ($iasl -h > /dev/null 2>&1) &&
+ (lscpu | grep "Byte Order" | grep --quiet "Little Endian" ); then
echo "IASL=$iasl" >> $config_host_mak
fi
echo "CC_I386=$cc_i386" >> $config_host_mak
--
1.8.3.1
next reply other threads:[~2014-03-20 21:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 21:14 Marcel Apfelbaum [this message]
2014-03-20 21:57 ` [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines Paolo Bonzini
2014-03-20 22:00 ` Marcel Apfelbaum
2014-03-20 22:06 ` Marcel Apfelbaum
2014-03-20 22:17 ` Peter Maydell
2014-03-20 22:41 ` Marcel Apfelbaum
2014-03-20 23:03 ` Peter Maydell
2014-03-23 9:52 ` Michael S. Tsirkin
2014-03-23 12:31 ` Peter Maydell
2014-03-23 9:51 ` Michael S. Tsirkin
2014-03-20 22:26 ` Laszlo Ersek
2014-03-20 22:33 ` Marcel Apfelbaum
2014-03-20 22:50 ` Laszlo Ersek
2014-03-20 23:16 ` Paolo Bonzini
2014-03-23 9:49 ` Michael S. Tsirkin
2014-03-23 12:14 ` Peter Maydell
2014-03-23 12:32 ` Marcel Apfelbaum
2014-03-23 12:48 ` Peter Maydell
2014-03-23 13:00 ` Marcel Apfelbaum
2014-03-23 12:51 ` Paolo Bonzini
2014-03-23 13:17 ` Marcel Apfelbaum
2014-03-23 13:58 ` Michael S. Tsirkin
2014-03-24 11:02 ` Andreas Färber
2014-03-25 3:48 ` Alexey Kardashevskiy
2014-03-23 12:32 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395350099-14664-1-git-send-email-marcel.a@redhat.com \
--to=marcel.a@redhat.com \
--cc=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).