From: Beniamino Galvani <b.galvani@gmail.com>
To: qemu-devel@nongnu.org
Cc: Beniamino Galvani <b.galvani@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Li Guang <lig.fnst@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH v4 7/7] allwinner-emac: update irq status after writes to interrupt registers
Date: Thu, 20 Mar 2014 22:25:19 +0100 [thread overview]
Message-ID: <1395350719-3778-8-git-send-email-b.galvani@gmail.com> (raw)
In-Reply-To: <1395350719-3778-1-git-send-email-b.galvani@gmail.com>
The irq line status must be updated after writes to the INT_CTL and
INT_STA registers.
Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
hw/net/allwinner_emac.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c
index 91931ac..d780ba0 100644
--- a/hw/net/allwinner_emac.c
+++ b/hw/net/allwinner_emac.c
@@ -391,9 +391,11 @@ static void aw_emac_write(void *opaque, hwaddr offset, uint64_t value,
break;
case EMAC_INT_CTL_REG:
s->int_ctl = value;
+ aw_emac_update_irq(s);
break;
case EMAC_INT_STA_REG:
s->int_sta &= ~value;
+ aw_emac_update_irq(s);
break;
case EMAC_MAC_MADR_REG:
s->phy_target = value;
--
1.7.10.4
prev parent reply other threads:[~2014-03-20 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 21:25 [Qemu-devel] [PATCH v4 0/7] Allwinner A10 fixes Beniamino Galvani
2014-03-20 21:25 ` [Qemu-devel] [PATCH v4 1/7] allwinner-a10-pic: set vector address when an interrupt is pending Beniamino Galvani
2014-03-20 21:25 ` [Qemu-devel] [PATCH v4 2/7] allwinner-a10-pic: fix behaviour of pending register Beniamino Galvani
2014-03-20 21:25 ` [Qemu-devel] [PATCH v4 3/7] allwinner-a10-pit: avoid generation of spurious interrupts Beniamino Galvani
2014-03-20 21:25 ` [Qemu-devel] [PATCH v4 4/7] allwinner-a10-pit: use level triggered interrupts Beniamino Galvani
2014-03-20 21:25 ` [Qemu-devel] [PATCH v4 5/7] allwinner-a10-pit: implement prescaler and source selection Beniamino Galvani
2014-03-24 23:49 ` Peter Crosthwaite
2014-03-25 18:08 ` Beniamino Galvani
2014-03-20 21:25 ` [Qemu-devel] [PATCH v4 6/7] allwinner-emac: set autonegotiation complete bit on link up Beniamino Galvani
2014-03-20 21:25 ` Beniamino Galvani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395350719-3778-8-git-send-email-b.galvani@gmail.com \
--to=b.galvani@gmail.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).