qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.a@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, aik@ozlabs.ru,
	mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com,
	Paolo Bonzini <pbonzini@redhat.com>,
	afaerber@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines
Date: Fri, 21 Mar 2014 00:33:57 +0200	[thread overview]
Message-ID: <1395354837.21800.12.camel@localhost.localdomain> (raw)
In-Reply-To: <532B6B27.2080105@redhat.com>

On Thu, 2014-03-20 at 23:26 +0100, Laszlo Ersek wrote:
> On 03/20/14 23:06, Marcel Apfelbaum wrote:
> > On Thu, 2014-03-20 at 22:57 +0100, Paolo Bonzini wrote:
> >> Il 20/03/2014 22:14, Marcel Apfelbaum ha scritto:
> >>> +# All known versions of iasl on BE machines are broken.
> >>> +# TODO: add detection code once a non-broken version makes an appearance.
> >>> +if ($iasl -h > /dev/null 2>&1) &&
> >>> +   (lscpu | grep "Byte Order" | grep --quiet "Little Endian" ); then
> >>
> >> lscpu is not portable.
> > I am open to suggestions...
> > I'll try to come up with something else.
> 
> The printf and od utilities are portable. You can use printf to print a
> character string, and use od to group that character string into
> multibyte integers in the native byte order.
> 
> Example:
> 
>   X=$(printf '\336\255\276\357' | od -A n -t x4)
Hi Laszlo,
Thanks for the help!

I've seen something like that somewhere, but I didn't quite like it.
I was looking for something more elegant as I was *almost* sure
this kind of solution will not pass the reviews :)

But maybe I'll try this, let's see what happens,
Thanks!
Marcel

> 
> This sets X to " efbeadde" on little endian, and " deadbeef" on big endian.
> 
> Laszlo

  reply	other threads:[~2014-03-20 22:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 21:14 [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run iasl on big endian machines Marcel Apfelbaum
2014-03-20 21:57 ` Paolo Bonzini
2014-03-20 22:00   ` Marcel Apfelbaum
2014-03-20 22:06   ` Marcel Apfelbaum
2014-03-20 22:17     ` Peter Maydell
2014-03-20 22:41       ` Marcel Apfelbaum
2014-03-20 23:03         ` Peter Maydell
2014-03-23  9:52           ` Michael S. Tsirkin
2014-03-23 12:31             ` Peter Maydell
2014-03-23  9:51       ` Michael S. Tsirkin
2014-03-20 22:26     ` Laszlo Ersek
2014-03-20 22:33       ` Marcel Apfelbaum [this message]
2014-03-20 22:50         ` Laszlo Ersek
2014-03-20 23:16         ` Paolo Bonzini
2014-03-23  9:49           ` Michael S. Tsirkin
2014-03-23 12:14             ` Peter Maydell
2014-03-23 12:32               ` Marcel Apfelbaum
2014-03-23 12:48                 ` Peter Maydell
2014-03-23 13:00                   ` Marcel Apfelbaum
2014-03-23 12:51                 ` Paolo Bonzini
2014-03-23 13:17                   ` Marcel Apfelbaum
2014-03-23 13:58                     ` Michael S. Tsirkin
2014-03-24 11:02             ` Andreas Färber
2014-03-25  3:48               ` Alexey Kardashevskiy
2014-03-23 12:32           ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395354837.21800.12.camel@localhost.localdomain \
    --to=marcel.a@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=lersek@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).