From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR4x5-00012s-TL for qemu-devel@nongnu.org; Fri, 21 Mar 2014 15:18:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WR4wx-0006hG-KU for qemu-devel@nongnu.org; Fri, 21 Mar 2014 15:17:59 -0400 Received: from greensocs.com ([178.33.234.66]:46148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WR4wx-0006h8-Eg for qemu-devel@nongnu.org; Fri, 21 Mar 2014 15:17:51 -0400 From: fred.konrad@greensocs.com Date: Fri, 21 Mar 2014 20:17:31 +0100 Message-Id: <1395429454-24690-10-git-send-email-fred.konrad@greensocs.com> In-Reply-To: <1395429454-24690-1-git-send-email-fred.konrad@greensocs.com> References: <1395429454-24690-1-git-send-email-fred.konrad@greensocs.com> Subject: [Qemu-devel] [RFC PATCH 09/12] gdbstub: allow reverse execution in gdb stub. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mark.burton@greensocs.com, fred.konrad@greensocs.com From: KONRAD Frederic This allows gdb to reverse step QEMU: reverse-stepi and reverse-cont commands are allowed. When step_backward is called, QEMU restores a snapshot before the actual instruction and stops (with a debug exit) when the previous instruction is reached. Signed-off-by: KONRAD Frederic --- gdbstub.c | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 8afe0b7..99769af 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -33,6 +33,7 @@ #include "sysemu/char.h" #include "sysemu/sysemu.h" #include "exec/gdbstub.h" +#include "reverse-execution.h" #endif #define MAX_PACKET_LENGTH 4096 @@ -1113,6 +1114,17 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) if (cc->gdb_core_xml_file != NULL) { pstrcat(buf, sizeof(buf), ";qXfer:features:read+"); } + + #ifndef CONFIG_USER_ONLY + /* + * When reverse execution is enabled those additional features must + * be set so GDB allows reverse-stepi and reverse-continue command. + */ + if (cexe_is_enabled()) { + pstrcat(buf, sizeof(buf), ";ReverseStep+;ReverseContinue+"); + } + #endif /* !CONFIG_USER_ONLY */ + put_packet(s, buf); break; } @@ -1161,7 +1173,23 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } /* Unrecognised 'q' command. */ goto unknown_command; - + #ifndef CONFIG_USER_ONLY + case 'b': + /* Reverse execution. */ + switch (*p) { + case 's': + cexe_step_backward(s->c_cpu, 1); + break; + case 'c': + cexe_continue_backward(s->c_cpu); + break; + default: + buf[0] = '\0'; + put_packet(s, buf); + break; + } + break; + #endif /* !CONFIG_USER_ONLY */ default: unknown_command: /* put empty packet */ @@ -1221,6 +1249,7 @@ static void gdb_vm_state_change(void *opaque, int running, RunState state) ret = GDB_SIGNAL_TRAP; break; case RUN_STATE_PAUSED: + cexe_stop_reverse_continue(); ret = GDB_SIGNAL_INT; break; case RUN_STATE_SHUTDOWN: -- 1.8.1.4