From: Prasad Joshi <prasadjoshi.linux@gmail.com>
To: prasadjoshi.linux@gmail.com
Cc: peter.maydell@linaro.org, stefanha@redhat.com,
v.maffione@gmail.com, aik@ozlabs.ru, jan.kiszka@siemens.com,
riku.voipio@iki.fi, agraf@suse.de, chouteau@adacore.com,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org, av1474@comtv.ru,
kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com,
g.lettieri@iet.unipi.it, alex@alex.org.uk, rizzo@iet.unipi.it,
afaerber@suse.de
Subject: [Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot
Date: Sun, 23 Mar 2014 14:58:38 +0530 [thread overview]
Message-ID: <1395566923-5074-1-git-send-email-prasadjoshi.linux@gmail.com> (raw)
CSMKeyControll function is supposed to set the top level latch for each
slot. However, at the moment, it incorrectly updates only the first
slot. Patch fixes the problem.
Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
---
hw/audio/fmopl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index 290a224..eb60c12 100644
--- a/hw/audio/fmopl.c
+++ b/hw/audio/fmopl.c
@@ -725,7 +725,7 @@ INLINE void CSMKeyControll(OPL_CH *CH)
OPL_KEYOFF(slot2);
/* total level latch */
slot1->TLL = slot1->TL + (CH->ksl_base>>slot1->ksl);
- slot1->TLL = slot1->TL + (CH->ksl_base>>slot1->ksl);
+ slot2->TLL = slot2->TL + (CH->ksl_base>>slot2->ksl);
/* key on */
CH->op1_out[0] = CH->op1_out[1] = 0;
OPL_KEYON(slot1);
--
1.8.1.2
next reply other threads:[~2014-03-23 9:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-23 9:28 Prasad Joshi [this message]
2014-03-23 9:28 ` [Qemu-devel] [PATCH 2/6] intc/openpic_kvm: fix MemListener delete regiion callback function Prasad Joshi
2014-03-24 14:25 ` Andreas Färber
2014-04-02 8:54 ` Alexander Graf
2014-04-02 10:53 ` Andreas Färber
2014-04-02 11:32 ` Alexander Graf
2014-03-23 9:28 ` [Qemu-devel] [PATCH 3/6] pcnet: remove duplicate assignment Prasad Joshi
2014-03-24 13:18 ` Stefan Hajnoczi
2014-03-25 12:32 ` Stefan Hajnoczi
2014-03-23 9:28 ` [Qemu-devel] [PATCH 4/6] hw/timer/grlib_gptimer: remove unnecessary assignment Prasad Joshi
2014-03-27 5:16 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-23 9:28 ` [Qemu-devel] [PATCH 5/6] linux-user: remove duplicate statement Prasad Joshi
2014-03-24 8:57 ` Riku Voipio
2014-03-27 5:17 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-23 9:28 ` [Qemu-devel] [PATCH 6/6] net: netmap_poll must update both read/write poll state Prasad Joshi
2014-03-24 13:18 ` Stefan Hajnoczi
2014-03-25 12:31 ` Stefan Hajnoczi
2014-03-24 13:19 ` [Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot Stefan Hajnoczi
2014-03-24 13:22 ` Peter Maydell
2014-03-24 14:17 ` Andreas Färber
2014-03-25 9:00 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395566923-5074-1-git-send-email-prasadjoshi.linux@gmail.com \
--to=prasadjoshi.linux@gmail.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex@alex.org.uk \
--cc=aliguori@amazon.com \
--cc=av1474@comtv.ru \
--cc=chouteau@adacore.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rizzo@iet.unipi.it \
--cc=stefanha@redhat.com \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).