From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WRhZL-00070I-PF
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 08:32:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WRhZF-0007HC-Pp
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 08:32:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53625)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WRhZF-0007H4-J2
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 08:31:57 -0400
Message-ID: <1395577935.5673.16.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.a@redhat.com>
Date: Sun, 23 Mar 2014 14:32:15 +0200
In-Reply-To: <532B76E5.7090608@redhat.com>
References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com>
	<532B645B.5020507@redhat.com>
	<1395353214.21800.6.camel@localhost.localdomain>
	<532B6B27.2080105@redhat.com>
	<1395354837.21800.12.camel@localhost.localdomain>
	<532B76E5.7090608@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run
 iasl on big endian machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, aik@ozlabs.ru, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, Laszlo Ersek <lersek@redhat.com>, afaerber@suse.de, rth@twiddle.net

On Fri, 2014-03-21 at 00:16 +0100, Paolo Bonzini wrote:
> Il 20/03/2014 23:33, Marcel Apfelbaum ha scritto:
> > I've seen something like that somewhere, but I didn't quite like it.
> > I was looking for something more elegant as I was *almost* sure
> > this kind of solution will not pass the reviews :)
> >
> > But maybe I'll try this, let's see what happens,
> 
> If all you're looking for is bigendian (disabling iasl disassembly on 
> bigendian makes sense), your patch v2 is fine.

Thanks Paolo, I thought so too, but Michael NACKED it having a valid point:
We should check this at configure time... .

Anyway, if only iasl dis-assembler has issues, this can be seen as acpi test's
problem and handled inside the test.

Thanks,
Marcel
> 
> Assembling ASL on bigendian is supported by at least Fedora and Debian 
> (and hence Ubuntu).
> 
> Paolo