From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WRhZr-0007ia-4a
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 08:32:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WRhZl-0007LC-5z
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 08:32:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12714)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WRhZk-0007L6-U6
	for qemu-devel@nongnu.org; Sun, 23 Mar 2014 08:32:29 -0400
Message-ID: <1395577967.5673.17.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.a@redhat.com>
Date: Sun, 23 Mar 2014 14:32:47 +0200
In-Reply-To: <CAFEAcA8XSA75gXdTgD2W5R+QYuKL2_Zy+YWTU5KnfW2PPs2fiw@mail.gmail.com>
References: <1395350099-14664-1-git-send-email-marcel.a@redhat.com>
	<532B645B.5020507@redhat.com>
	<1395353214.21800.6.camel@localhost.localdomain>
	<532B6B27.2080105@redhat.com>
	<1395354837.21800.12.camel@localhost.localdomain>
	<532B76E5.7090608@redhat.com> <20140323094943.GA6989@redhat.com>
	<CAFEAcA8XSA75gXdTgD2W5R+QYuKL2_Zy+YWTU5KnfW2PPs2fiw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.0 V3] tests/acpi-test: do not run
 iasl on big endian machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, Michael Tokarev <mjt@tls.msk.ru>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Sun, 2014-03-23 at 12:14 +0000, Peter Maydell wrote:
> On 23 March 2014 09:49, Michael S. Tsirkin <mst@redhat.com> wrote:
> > At this point I'm confused.
> > If iasl compiler is broken, we should detect and fix that.
> > It might be ok to just detect endian-ness as a quick work-around.
> > BTW configure already has code to detect endian-ness:
> > if test "$bigendian" = "yes" ; then
> >   echo "HOST_WORDS_BIGENDIAN=y" >> $config_host_mak
> > fi
> 
> That's the endianness of the machine we're compiling QEMU
> for, not the endianness of the machine we're compiling QEMU
> on. If for instance you're on x86_64 cross-compiling for PPC
> then HOST_WORDS_BIGENDIAN is true, but the iasl you use
> in the build process will be running on a little endian machine.

Hi Peter, are you sure about this?
I saw the 'target_bigendian' that does what you described above.
$bigendian is the result of a little C program that checks *host's* endian-ness.
Of course I might have missed something.

By the way, considering what Paolo said that the iasl compiler does work
for BE machines (the dis-assembler has the problem), leads me to see this issue
as the test's problem.
So I am going to leave the 'configure' with no modifications
and check inside the test itself that the expected files can be disassembled.

Thanks,
Marcel


> 
> thanks
> -- PMM