From: Marcel Apfelbaum <marcel.a@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, famz@redhat.com, stefanha@redhat.com,
mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
stefano.stabellini@eu.citrix.com, agraf@suse.de,
lcapitulino@redhat.com, aliguori@amazon.com, alex@alex.org.uk,
afaerber@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 4/5] hw/ppc: remove QEMUMachine indirection
Date: Tue, 25 Mar 2014 22:11:33 +0200 [thread overview]
Message-ID: <1395778293.14459.0.camel@localhost.localdomain> (raw)
In-Reply-To: <53318C1A.2000602@redhat.com>
On Tue, 2014-03-25 at 15:00 +0100, Paolo Bonzini wrote:
> Il 25/03/2014 14:46, Marcel Apfelbaum ha scritto:
> > + mc->name = "pseries",
> > + mc->desc = "pSeries Logical Partition (PAPR compliant)",
> > + mc->is_default = 1,
> > + mc->init = ppc_spapr_init,
> > + mc->reset = ppc_spapr_reset,
> > + mc->block_default_type = IF_SCSI,
> > + mc->max_cpus = MAX_CPUS,
> > + mc->no_parallel = 1,
> > + mc->default_boot_order = NULL,
> > + mc->kvm_type = spapr_kvm_type,
>
> Semicolons instead of commas. :)
Noted, thanks!
Marcel
>
> Paolo
next prev parent reply other threads:[~2014-03-25 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 13:46 [Qemu-devel] [PATCH 0/5] remove QEMUMachine indirection from MachineClass Marcel Apfelbaum
2014-03-25 13:46 ` [Qemu-devel] [PATCH 1/5] hw/boards.h: add QEMUMachine's fields to MachineClass Marcel Apfelbaum
2014-03-25 13:46 ` [Qemu-devel] [PATCH 2/5] machine: remove QEMUMachine indirection from MachineClass Marcel Apfelbaum
2014-03-25 13:46 ` [Qemu-devel] [PATCH 3/5] machine: replace QEMUMachine by MachineClass in accelerator configuration Marcel Apfelbaum
2014-03-25 13:46 ` [Qemu-devel] [PATCH 4/5] hw/ppc: remove QEMUMachine indirection Marcel Apfelbaum
2014-03-25 14:00 ` Paolo Bonzini
2014-03-25 20:11 ` Marcel Apfelbaum [this message]
2014-03-25 13:46 ` [Qemu-devel] [PATCH 5/5] vl.c: Remove QEMUMachine usage Marcel Apfelbaum
-- strict thread matches above, loose matches on Subject: below --
2014-03-25 14:53 [Qemu-devel] [PATCH 0/5] remove QEMUMachine indirection from MachineClass Marcel Apfelbaum
2014-03-25 14:53 ` [Qemu-devel] [PATCH 4/5] hw/ppc: remove QEMUMachine indirection Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395778293.14459.0.camel@localhost.localdomain \
--to=marcel.a@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=alex@alex.org.uk \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).