From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] display/qxl: don't abort on reset with non empty rings
Date: Wed, 26 Mar 2014 11:35:32 +0100 [thread overview]
Message-ID: <1395830132.16491.10.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1395653944-14544-1-git-send-email-alevy@redhat.com>
On Mo, 2014-03-24 at 11:39 +0200, Alon Levy wrote:
> The command ring and cursor rings are pushed to by the guest, and
> cleared asynchronously by qemu's spice thread. It is easy to have
> them non empty by bad guest behaviour, and we must never abort on bad
> guest behaviour.
I think we should either use the qxl_guest_bug trace point if we want
report this for troubleshooting reasons. Or simply drop qxl_check_state
altogether ...
cheers,
Gerd
prev parent reply other threads:[~2014-03-26 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 9:39 [Qemu-devel] [PATCH] display/qxl: don't abort on reset with non empty rings Alon Levy
2014-03-26 10:35 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395830132.16491.10.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).