From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSlBP-00027K-2N for qemu-devel@nongnu.org; Wed, 26 Mar 2014 06:35:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSlBI-0000qh-P4 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 06:35:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSlBI-0000qU-9r for qemu-devel@nongnu.org; Wed, 26 Mar 2014 06:35:36 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2QAZZuH016596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Mar 2014 06:35:35 -0400 Message-ID: <1395830132.16491.10.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 26 Mar 2014 11:35:32 +0100 In-Reply-To: <1395653944-14544-1-git-send-email-alevy@redhat.com> References: <1395653944-14544-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] display/qxl: don't abort on reset with non empty rings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On Mo, 2014-03-24 at 11:39 +0200, Alon Levy wrote: > The command ring and cursor rings are pushed to by the guest, and > cleared asynchronously by qemu's spice thread. It is easy to have > them non empty by bad guest behaviour, and we must never abort on bad > guest behaviour. I think we should either use the qxl_guest_bug trace point if we want report this for troubleshooting reasons. Or simply drop qxl_check_state altogether ... cheers, Gerd