From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: prasadjoshi.linux@gmail.com
Subject: [Qemu-devel] [PULL 1/2] scsi: check req pointer before dereferencing it
Date: Wed, 26 Mar 2014 13:21:10 +0100 [thread overview]
Message-ID: <1395836471-5816-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1395836471-5816-1-git-send-email-pbonzini@redhat.com>
From: Prasad Joshi <prasadjoshi.linux@gmail.com>
Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/vmw_pvscsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
index 7d344b9..e35bff7 100644
--- a/hw/scsi/vmw_pvscsi.c
+++ b/hw/scsi/vmw_pvscsi.c
@@ -479,12 +479,13 @@ static void
pvscsi_command_complete(SCSIRequest *req, uint32_t status, size_t resid)
{
PVSCSIRequest *pvscsi_req = req->hba_private;
- PVSCSIState *s = pvscsi_req->dev;
+ PVSCSIState *s;
if (!pvscsi_req) {
trace_pvscsi_command_complete_not_found(req->tag);
return;
}
+ s = pvscsi_req->dev;
if (resid) {
/* Short transfer. */
--
1.8.5.3
next prev parent reply other threads:[~2014-03-26 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 12:21 [Qemu-devel] [PULL 0/2] SCSI changes for 2.0 Paolo Bonzini
2014-03-26 12:21 ` Paolo Bonzini [this message]
2014-03-26 12:21 ` [Qemu-devel] [PULL 2/2] spapr_vscsi: remove duplicate condition check Paolo Bonzini
2014-03-26 17:12 ` [Qemu-devel] [PULL 0/2] SCSI changes for 2.0 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395836471-5816-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=prasadjoshi.linux@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).