From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSmpr-0001w9-D6 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 08:21:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSmpi-0000Yd-5H for qemu-devel@nongnu.org; Wed, 26 Mar 2014 08:21:35 -0400 Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:64880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSmpi-0000Y9-21 for qemu-devel@nongnu.org; Wed, 26 Mar 2014 08:21:26 -0400 Received: by mail-qg0-f46.google.com with SMTP id e89so704695qgf.5 for ; Wed, 26 Mar 2014 05:21:25 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 26 Mar 2014 13:21:10 +0100 Message-Id: <1395836471-5816-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1395836471-5816-1-git-send-email-pbonzini@redhat.com> References: <1395836471-5816-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 1/2] scsi: check req pointer before dereferencing it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: prasadjoshi.linux@gmail.com From: Prasad Joshi Signed-off-by: Prasad Joshi Signed-off-by: Paolo Bonzini --- hw/scsi/vmw_pvscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 7d344b9..e35bff7 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -479,12 +479,13 @@ static void pvscsi_command_complete(SCSIRequest *req, uint32_t status, size_t resid) { PVSCSIRequest *pvscsi_req = req->hba_private; - PVSCSIState *s = pvscsi_req->dev; + PVSCSIState *s; if (!pvscsi_req) { trace_pvscsi_command_complete_not_found(req->tag); return; } + s = pvscsi_req->dev; if (resid) { /* Short transfer. */ -- 1.8.5.3