qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [maybe-for-2.0 2/2] vl.c: Improve message when no default machine is found
Date: Wed, 26 Mar 2014 21:22:45 +0200	[thread overview]
Message-ID: <1395861765.313.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1395775613-30984-3-git-send-email-peter.maydell@linaro.org>

On Tue, 2014-03-25 at 19:26 +0000, Peter Maydell wrote:
> Improve the clarity of the message QEMU prints when the user
> doesn't specify a machine model to use and there is no default.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  vl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 2355227..9975e5a 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3929,7 +3929,8 @@ int main(int argc, char **argv, char **envp)
>  #endif
>  
>      if (machine_class == NULL) {
> -        fprintf(stderr, "No machine found.\n");
> +        fprintf(stderr, "No machine specified, and there is no default.\n"
> +                "Use -machine help to list supported machines!\n");
+1

Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>

>          exit(1);
>      }
>  

  reply	other threads:[~2014-03-26 19:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25 19:26 [Qemu-devel] [maybe-for-2.0 0/2] hw/arm: Don't specify any default board Peter Maydell
2014-03-25 19:26 ` [Qemu-devel] [maybe-for-2.0 1/2] hw/arm: Stop specifying integratorcp as the " Peter Maydell
2014-03-28 11:17   ` [Qemu-devel] [maybe-for-2.0 1/2] hw/arm: Stop specifyingintegratorcp as the default boardd Alex Bennée
2014-03-28 11:35     ` Peter Maydell
2014-03-25 19:26 ` [Qemu-devel] [maybe-for-2.0 2/2] vl.c: Improve message when no default machine is found Peter Maydell
2014-03-26 19:22   ` Marcel Apfelbaum [this message]
2014-03-28 11:16   ` [Qemu-devel] [maybe-for-2.0 2/2] vl.c: Improve message when nodefault machine is foundd Alex Bennée
2014-03-26  9:53 ` [Qemu-devel] [maybe-for-2.0 0/2] hw/arm: Don't specify any default board Paolo Bonzini
2014-03-26 15:16 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395861765.313.3.camel@localhost.localdomain \
    --to=marcel.apfelbaum@gmail.com \
    --cc=marcel.a@redhat.com \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).