From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT22d-00067r-7K for qemu-devel@nongnu.org; Thu, 27 Mar 2014 00:35:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WT22U-0005DM-Or for qemu-devel@nongnu.org; Thu, 27 Mar 2014 00:35:47 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:36084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WT22T-0005Be-Pr for qemu-devel@nongnu.org; Thu, 27 Mar 2014 00:35:38 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Mar 2014 14:35:32 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 251FB3578054 for ; Thu, 27 Mar 2014 15:35:30 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s2R4F0DR10551774 for ; Thu, 27 Mar 2014 15:15:01 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s2R4ZSX4028122 for ; Thu, 27 Mar 2014 15:35:28 +1100 From: Alexey Kardashevskiy Date: Thu, 27 Mar 2014 15:35:26 +1100 Message-Id: <1395894926-16633-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH] exec: Limit translation limiting in address_space_translate to xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , Paolo Bonzini The address_space_translate() function cuts the returned plen (page size) to hardcoded TARGET_PAGE_SIZE. This function can be used on pages bigger than that so this limiting should not be used on such pages. Since originally the limiting was introduced for XEN, we can safely limit this piece of code to XEN. So does the patch. Suggested-by: Paolo Bonzini Signed-off-by: Alexey Kardashevskiy --- I need this change for VFIO-on-sPAPR series as it is going to support 16MB IOMMU pages. Thanks. --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 91513c6..cf12049 100644 --- a/exec.c +++ b/exec.c @@ -380,7 +380,7 @@ MemoryRegion *address_space_translate(AddressSpace *as, hwaddr addr, as = iotlb.target_as; } - if (memory_access_is_direct(mr, is_write)) { + if (xen_enabled() && memory_access_is_direct(mr, is_write)) { hwaddr page = ((addr & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE) - addr; len = MIN(page, len); } -- 1.8.4.rc4