From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56007)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1WT59z-0006ZJ-W8
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 03:55:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1WT59r-00086L-8K
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 03:55:35 -0400
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:49388)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.apfelbaum@gmail.com>) id 1WT59q-000861-VW
	for qemu-devel@nongnu.org; Thu, 27 Mar 2014 03:55:27 -0400
Received: by mail-wi0-f176.google.com with SMTP id r20so5657455wiv.15
	for <qemu-devel@nongnu.org>; Thu, 27 Mar 2014 00:55:26 -0700 (PDT)
Message-ID: <1395906947.313.10.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Date: Thu, 27 Mar 2014 09:55:47 +0200
In-Reply-To: <53337BEB.90305@gmail.com>
References: <53337BEB.90305@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in
 configure_accelerator()
Reply-To: marcel.a@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, aliguori@amazon.com

On Thu, 2014-03-27 at 09:16 +0800, Chen Gang wrote:
> At present, each 'opt_name' of 'accel_list' is uniq with each other, so
> 'buf' can only match one 'opt_name'.
> 
> When drop into the matching code block, can 'break' outside related
> 'for' looping after finish processing it (just like the other 'break'
> within the matching block).
> 
> After print "... not support for this target", it can avoid to print
> "... accelerator does not exist".
Hi,
Thanks for the patch!

I would re-write
1. The commit subject to:
   Fix wrong warning on configure_accelerator
2. The commit message to:
   No need to continue to iterate over the accelerators list
   after a match is found, even if it is not supported.

> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  vl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 842e897..b4f98fa 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2709,7 +2709,7 @@ static int configure_accelerator(QEMUMachine *machine)
>                  if (!accel_list[i].available()) {
>                      printf("%s not supported for this target\n",
>                             accel_list[i].name);
> -                    continue;
> +                    break;
Seems like the right thing to do.

Thanks,
Marcel

>                  }
>                  *(accel_list[i].allowed) = true;
>                  ret = accel_list[i].init(machine);