From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 09/23] CODING_STYLE: Section about mixed declarations
Date: Thu, 27 Mar 2014 19:28:14 +0400 [thread overview]
Message-ID: <1395934108-1694-10-git-send-email-mjt@msgid.tls.msk.ru> (raw)
In-Reply-To: <1395934108-1694-1-git-send-email-mjt@msgid.tls.msk.ru>
From: Eduardo Habkost <ehabkost@redhat.com>
We had an unwritten rule about declarations having to be at beginning of
blocks. Make it a written rule.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
CODING_STYLE | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/CODING_STYLE b/CODING_STYLE
index dcbce28..4280945 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -84,3 +84,10 @@ and clarity it comes on a line by itself:
Rationale: a consistent (except for functions...) bracing style reduces
ambiguity and avoids needless churn when lines are added or removed.
Furthermore, it is the QEMU coding style.
+
+5. Declarations
+
+Mixed declarations (interleaving statements and declarations within blocks)
+are not allowed; declarations should be at the beginning of blocks. In other
+words, the code should not generate warnings if using GCC's
+-Wdeclaration-after-statement option.
--
1.7.10.4
next prev parent reply other threads:[~2014-03-27 16:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 15:28 [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27 Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 02/23] target-arm: Add missing 'static' attribute Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 03/23] hw/ide: Add missing 'static' attributes Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 04/23] util: Add 'static' attribute to function implementation Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 05/23] target-i386: Add missing 'static' and 'const' attributes Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 06/23] fix return check for KVM_GET_DIRTY_LOG ioctl Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 07/23] doc: update sun4m documentation Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 08/23] doc: update default PowerPC framebuffer settings Michael Tokarev
2014-03-27 15:28 ` Michael Tokarev [this message]
2014-03-27 15:28 ` [Qemu-devel] [PULL 10/23] target-i386: Avoid shifting left into sign bit Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 11/23] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 14/23] target-mips: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 16/23] hw/intc/openpic: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 17/23] hw/ppc: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 18/23] tests/libqos/pci-pc: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 19/23] hw/intc/slavio_intctl: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 21/23] hw/pci-host/apb.c: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 23/23] linux-user: remove duplicate statement Michael Tokarev
2014-03-27 17:10 ` [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395934108-1694-10-git-send-email-mjt@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).