qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
	Mario Smarduch <m.smarduch@samsung.com>
Subject: [Qemu-devel] [PULL 06/23] fix return check for KVM_GET_DIRTY_LOG ioctl
Date: Thu, 27 Mar 2014 19:28:11 +0400	[thread overview]
Message-ID: <1395934108-1694-7-git-send-email-mjt@msgid.tls.msk.ru> (raw)
In-Reply-To: <1395934108-1694-1-git-send-email-mjt@msgid.tls.msk.ru>

From: Mario Smarduch <m.smarduch@samsung.com>

Fix return condition check from kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) to
handle internal failures or no support for memory slot dirty bitmap.
Otherwise the ioctl succeeds and continues with migration.
Addresses BUG# 1294227

Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 kvm-all.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kvm-all.c b/kvm-all.c
index 82a9119..cd4111d 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -441,7 +441,7 @@ static int kvm_physical_sync_dirty_bitmap(MemoryRegionSection *section)
 
         d.slot = mem->slot;
 
-        if (kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
+        if (kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) < 0) {
             DPRINTF("ioctl failed %d\n", errno);
             ret = -1;
             break;
-- 
1.7.10.4

  parent reply	other threads:[~2014-03-27 15:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 15:28 [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27 Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 02/23] target-arm: Add missing 'static' attribute Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 03/23] hw/ide: Add missing 'static' attributes Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 04/23] util: Add 'static' attribute to function implementation Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 05/23] target-i386: Add missing 'static' and 'const' attributes Michael Tokarev
2014-03-27 15:28 ` Michael Tokarev [this message]
2014-03-27 15:28 ` [Qemu-devel] [PULL 07/23] doc: update sun4m documentation Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 08/23] doc: update default PowerPC framebuffer settings Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 09/23] CODING_STYLE: Section about mixed declarations Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 10/23] target-i386: Avoid shifting left into sign bit Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 11/23] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 14/23] target-mips: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 16/23] hw/intc/openpic: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 17/23] hw/ppc: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 18/23] tests/libqos/pci-pc: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 19/23] hw/intc/slavio_intctl: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 21/23] hw/pci-host/apb.c: " Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment Michael Tokarev
2014-03-27 15:28 ` [Qemu-devel] [PULL 23/23] linux-user: remove duplicate statement Michael Tokarev
2014-03-27 17:10 ` [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395934108-1694-7-git-send-email-mjt@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=m.smarduch@samsung.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).