From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTTWN-0006ur-4Y for qemu-devel@nongnu.org; Fri, 28 Mar 2014 05:56:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTTWG-00029d-PL for qemu-devel@nongnu.org; Fri, 28 Mar 2014 05:56:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTTWG-00029Y-GK for qemu-devel@nongnu.org; Fri, 28 Mar 2014 05:56:12 -0400 From: Stefan Hajnoczi Date: Fri, 28 Mar 2014 10:55:54 +0100 Message-Id: <1396000554-29501-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1396000554-29501-1-git-send-email-stefanha@redhat.com> References: <1396000554-29501-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v3 3/3] tests: correctly skip qtest on non-POSIX hosts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Andreas Faerber , Stefan Hajnoczi , sw@weilnetz.de qtest test cases only work on POSIX hosts. The following line only defines dependencies for qtest binaries on POSIX hosts: check-qtest-$(CONFIG_POSIX)=$(foreach TARGET,$(TARGETS),$(check-qtest-$(TARGET)-y)) But the QTEST_TARGETS definition earlier in the Makefile fails to check CONFIG_POSIX. This causes make targets to be generated for qtest test cases even though we don't know how to build the binaries. The following error message is printed when trying to run gtester on a binary that was never built: GLib-WARNING **: Failed to execute test binary: tests/endianness-test.exe: Failed to execute child process "tests/endianness-test.exe" (No such file or directory) This patch makes QTEST_TARGETS empty on non-POSIX hosts. This prevents the targets from being generated. Signed-off-by: Stefan Hajnoczi --- tests/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index ef286e7..0e3eb44 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -277,8 +277,10 @@ tests/qemu-iotests/socket_scm_helper$(EXESUF): tests/qemu-iotests/socket_scm_hel # QTest rules TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_DIRS))) +ifeq ($(CONFIG_POSIX),y) QTEST_TARGETS=$(foreach TARGET,$(TARGETS), $(if $(check-qtest-$(TARGET)-y), $(TARGET),)) -check-qtest-$(CONFIG_POSIX)=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y)) +check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y)) +endif qtest-obj-y = tests/libqtest.o libqemuutil.a libqemustub.a $(check-qtest-y): $(qtest-obj-y) -- 1.8.5.3