From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUDSP-0008Te-3y for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUDSJ-0003Ym-5N for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:17 -0400 Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:37146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUDSI-0003Yf-Tr for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:11 -0400 Received: by mail-ee0-f44.google.com with SMTP id e49so5647570eek.31 for ; Sun, 30 Mar 2014 03:59:10 -0700 (PDT) From: Hani Benhabiles Date: Sun, 30 Mar 2014 11:58:35 +0100 Message-Id: <1396177119-24955-14-git-send-email-kroosec@gmail.com> In-Reply-To: <1396177119-24955-1-git-send-email-kroosec@gmail.com> References: <1396177119-24955-1-git-send-email-kroosec@gmail.com> Subject: [Qemu-devel] [PATCH v2 13/17] monitor: Add host_net_add device argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com, stefanha@redhat.com, imammedo@redhat.com Also fix the parameters documentation. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 3 ++- hmp.h | 1 + monitor.c | 14 ++++++++++++++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8c674ba..9da5866 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1201,9 +1201,10 @@ ETEXI { .name = "host_net_add", .args_type = "device:s,opts:s?", - .params = "tap|user|socket|vde|netmap|dump [options]", + .params = "tap|user|socket|vde|bridge|dump [options]", .help = "add host VLAN client", .mhandler.cmd = net_host_device_add, + .command_completion = host_net_add_completion, }, STEXI diff --git a/hmp.h b/hmp.h index 3570530..c82fd87 100644 --- a/hmp.h +++ b/hmp.h @@ -109,5 +109,6 @@ void watchdog_action_completion(ReadLineState *rs, int nb_args, const char *str); void migrate_set_capability_completion(ReadLineState *rs, int nb_args, const char *str); +void host_net_add_completion(ReadLineState *rs, int nb_args, const char *str); #endif diff --git a/monitor.c b/monitor.c index 2974a66..4c20bc5 100644 --- a/monitor.c +++ b/monitor.c @@ -4605,6 +4605,20 @@ void migrate_set_capability_completion(ReadLineState *rs, int nb_args, } } +void host_net_add_completion(ReadLineState *rs, int nb_args, const char *str) +{ + if (nb_args != 2) { + return; + } + readline_set_completion_index(rs, strlen(str)); + add_completion_option(rs, str, "tap"); + add_completion_option(rs, str, "user"); + add_completion_option(rs, str, "socket"); + add_completion_option(rs, str, "vde"); + add_completion_option(rs, str, "dump"); + add_completion_option(rs, str, "bridge"); +} + static void monitor_find_completion_by_table(Monitor *mon, const mon_cmd_t *cmd_table, char **args, -- 1.8.3.2