From: Hani Benhabiles <kroosec@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com,
stefanha@redhat.com, imammedo@redhat.com
Subject: [Qemu-devel] [PATCH v2 14/17] readline: Make completion strings always unique.
Date: Sun, 30 Mar 2014 11:58:36 +0100 [thread overview]
Message-ID: <1396177119-24955-15-git-send-email-kroosec@gmail.com> (raw)
In-Reply-To: <1396177119-24955-1-git-send-email-kroosec@gmail.com>
There is no need to clutter the user's choices with repeating the same value
multiple times.
Signed-off-by: Hani Benhabiles <hani@linux.com>
---
util/readline.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/util/readline.c b/util/readline.c
index 8441be4..6aeae6a 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -263,6 +263,12 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline)
void readline_add_completion(ReadLineState *rs, const char *str)
{
if (rs->nb_completions < READLINE_MAX_COMPLETIONS) {
+ int i;
+ for (i = 0; i < rs->nb_completions; i++) {
+ if (!strcmp(rs->completions[i], str)) {
+ return;
+ }
+ }
rs->completions[rs->nb_completions++] = g_strdup(str);
}
}
--
1.8.3.2
next prev parent reply other threads:[~2014-03-30 10:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 10:58 [Qemu-devel] [PATCH v2 00/17] monitor: Completion support for various commands Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 01/17] monitor: Fix drive_del id argument type completion Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 02/17] monitor: Add command_completion callback to mon_cmd_t Hani Benhabiles
2014-04-11 17:14 ` Luiz Capitulino
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 03/17] monitor: Add device_add and device_del completion Hani Benhabiles
2014-04-11 17:30 ` Luiz Capitulino
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 04/17] monitor: Add chardev-remove id argument completion Hani Benhabiles
2014-04-11 17:36 ` Luiz Capitulino
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 05/17] monitor: Add chardev-add backend " Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 06/17] monitor: Add cpu index " Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 07/17] monitor: Add set_link arguments completion Hani Benhabiles
2014-04-11 17:40 ` Luiz Capitulino
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 08/17] monitor: Add netdev_add type argument completion Hani Benhabiles
2014-04-11 17:44 ` Luiz Capitulino
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 09/17] monitor: Add netdev_del id " Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 10/17] monitor: Add ringbuf_write and ringbuf_read " Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 11/17] monitor: Add watchdog_action " Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 12/17] monitor: Add migrate_set_capability completion Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 13/17] monitor: Add host_net_add device argument completion Hani Benhabiles
2014-03-30 10:58 ` Hani Benhabiles [this message]
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 15/17] monitor: Add host_net_remove arguments completion Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 16/17] monitor: Add mouse_set index argument completion Hani Benhabiles
2014-03-30 10:58 ` [Qemu-devel] [PATCH v2 17/17] monitor: Add delvm and loadvm " Hani Benhabiles
2014-04-11 17:50 ` [Qemu-devel] [PATCH v2 00/17] monitor: Completion support for various commands Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396177119-24955-15-git-send-email-kroosec@gmail.com \
--to=kroosec@gmail.com \
--cc=aliguori@amazon.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).