From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUDSQ-00005K-Ij for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUDSK-0003Z5-Kv for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:18 -0400 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:49375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUDSK-0003Yu-EN for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:12 -0400 Received: by mail-ee0-f48.google.com with SMTP id b57so5573199eek.35 for ; Sun, 30 Mar 2014 03:59:11 -0700 (PDT) From: Hani Benhabiles Date: Sun, 30 Mar 2014 11:58:36 +0100 Message-Id: <1396177119-24955-15-git-send-email-kroosec@gmail.com> In-Reply-To: <1396177119-24955-1-git-send-email-kroosec@gmail.com> References: <1396177119-24955-1-git-send-email-kroosec@gmail.com> Subject: [Qemu-devel] [PATCH v2 14/17] readline: Make completion strings always unique. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com, stefanha@redhat.com, imammedo@redhat.com There is no need to clutter the user's choices with repeating the same value multiple times. Signed-off-by: Hani Benhabiles --- util/readline.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/util/readline.c b/util/readline.c index 8441be4..6aeae6a 100644 --- a/util/readline.c +++ b/util/readline.c @@ -263,6 +263,12 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline) void readline_add_completion(ReadLineState *rs, const char *str) { if (rs->nb_completions < READLINE_MAX_COMPLETIONS) { + int i; + for (i = 0; i < rs->nb_completions; i++) { + if (!strcmp(rs->completions[i], str)) { + return; + } + } rs->completions[rs->nb_completions++] = g_strdup(str); } } -- 1.8.3.2