From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUDSC-0008Bh-HG for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUDS6-0003VF-IH for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:59:04 -0400 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:34019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUDS6-0003V0-BT for qemu-devel@nongnu.org; Sun, 30 Mar 2014 06:58:58 -0400 Received: by mail-ee0-f48.google.com with SMTP id b57so5549783eek.21 for ; Sun, 30 Mar 2014 03:58:57 -0700 (PDT) From: Hani Benhabiles Date: Sun, 30 Mar 2014 11:58:27 +0100 Message-Id: <1396177119-24955-6-git-send-email-kroosec@gmail.com> In-Reply-To: <1396177119-24955-1-git-send-email-kroosec@gmail.com> References: <1396177119-24955-1-git-send-email-kroosec@gmail.com> Subject: [Qemu-devel] [PATCH v2 05/17] monitor: Add chardev-add backend argument completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com, stefanha@redhat.com, imammedo@redhat.com Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 23 +++++++++++++++++++++++ 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 4f0f053..a411d4f 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1614,6 +1614,7 @@ ETEXI .params = "args", .help = "add chardev", .mhandler.cmd = hmp_chardev_add, + .command_completion = chardev_add_completion, }, STEXI diff --git a/hmp.h b/hmp.h index 42b4d6b..6de5d1a 100644 --- a/hmp.h +++ b/hmp.h @@ -98,5 +98,6 @@ void object_del_completion(ReadLineState *rs, int nb_args, const char *str); void device_add_completion(ReadLineState *rs, int nb_args, const char *str); void device_del_completion(ReadLineState *rs, int nb_args, const char *str); void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str); +void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str); #endif diff --git a/monitor.c b/monitor.c index 040da9b..27caa74 100644 --- a/monitor.c +++ b/monitor.c @@ -4278,6 +4278,29 @@ static const char *next_arg_type(const char *typestr) return (p != NULL ? ++p : typestr); } +void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str) +{ + size_t len; + ChardevBackendInfoList *list, *start; + + if (nb_args != 2) { + return; + } + len = strlen(str); + readline_set_completion_index(rs, len); + + start = list = qmp_query_chardev_backends(NULL); + while (list) { + const char *chr_name = list->value->name; + + if (!strncmp(chr_name, str, len)) { + readline_add_completion(rs, chr_name); + } + list = list->next; + } + qapi_free_ChardevBackendInfoList(start); +} + void device_add_completion(ReadLineState *rs, int nb_args, const char *str) { GSList *list, *elt; -- 1.8.3.2