From: Gerd Hoffmann <kraxel@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH] input: mouse_set should check input device type.
Date: Mon, 31 Mar 2014 08:12:29 +0200 [thread overview]
Message-ID: <1396246349.3108.1.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1396187381-31618-1-git-send-email-kroosec@gmail.com>
> + if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
> + INPUT_EVENT_MASK_ABS))) {
> + monitor_printf(mon, "Input device '%s' is not a mouse",
> + s->handler->name);
That should be error_report (I think, Markus?).
Otherwise the patch is fine.
cheers,
Gerd
next prev parent reply other threads:[~2014-03-31 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 13:49 [Qemu-devel] [PATCH] input: mouse_set should check input device type Hani Benhabiles
2014-03-31 6:12 ` Gerd Hoffmann [this message]
2014-03-31 12:45 ` Markus Armbruster
2014-03-31 22:10 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396246349.3108.1.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=kroosec@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).