From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WUVSd-0007mX-6h
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 02:12:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WUVSW-0005H3-Vw
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 02:12:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15572)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WUVSW-0005GN-Kr
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 02:12:36 -0400
Message-ID: <1396246349.3108.1.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 31 Mar 2014 08:12:29 +0200
In-Reply-To: <1396187381-31618-1-git-send-email-kroosec@gmail.com>
References: <1396187381-31618-1-git-send-email-kroosec@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] input: mouse_set should check input device
	type.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hani Benhabiles <kroosec@gmail.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com


> +        if (!(s->handler->mask & (INPUT_EVENT_MASK_REL |
> +                                  INPUT_EVENT_MASK_ABS))) {
> +            monitor_printf(mon, "Input device '%s' is not a mouse",
> +                           s->handler->name);

That should be error_report (I think, Markus?).

Otherwise the patch is fine.

cheers,
  Gerd