qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, afaerber@suse.de
Subject: [Qemu-devel] [PATCH for-2.0 6/7] tmp105-test: add a second sensor and test that one
Date: Mon, 31 Mar 2014 18:26:34 +0200	[thread overview]
Message-ID: <1396283195-6819-7-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1396283195-6819-1-git-send-email-pbonzini@redhat.com>

This will make it easier to reach the device under test via QOM.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/tmp105-test.c | 17 +++++++++--------
 5 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/tests/tmp105-test.c b/tests/tmp105-test.c
index 20a1894..4e640b4 100644
--- a/tests/tmp105-test.c
+++ b/tests/tmp105-test.c
@@ -15,10 +15,10 @@
 
 #define OMAP2_I2C_1_BASE 0x48070000
 
-#define N8X0_ADDR 0x48
+#define TMP105_TEST_ID   "tmp105-test"
+#define TMP105_TEST_ADDR 0x49
 
 static I2CAdapter *i2c;
-static uint8_t addr;
 
 static uint16_t tmp105_get16(I2CAdapter *i2c, uint8_t addr, uint8_t reg)
 {
@@ -61,14 +61,14 @@ static void send_and_receive(void)
 {
     uint16_t value;
 
-    value = tmp105_get16(i2c, addr, TMP105_REG_TEMPERATURE);
+    value = tmp105_get16(i2c, TMP105_TEST_ADDR, TMP105_REG_TEMPERATURE);
     g_assert_cmpuint(value, ==, 0);
 
     /* reset */
-    tmp105_set8(i2c, addr, TMP105_REG_CONFIG, 0);
+    tmp105_set8(i2c, TMP105_TEST_ADDR, TMP105_REG_CONFIG, 0);
 
-    tmp105_set16(i2c, addr, TMP105_REG_T_LOW, 0x1234);
-    tmp105_set16(i2c, addr, TMP105_REG_T_HIGH, 0x4231);
+    tmp105_set16(i2c, TMP105_TEST_ADDR, TMP105_REG_T_LOW, 0x1234);
+    tmp105_set16(i2c, TMP105_TEST_ADDR, TMP105_REG_T_HIGH, 0x4231);
 }
 
 int main(int argc, char **argv)
@@ -78,9 +78,10 @@ int main(int argc, char **argv)
 
     g_test_init(&argc, &argv, NULL);
 
-    s = qtest_start("-machine n800");
+    s = qtest_start("-machine n800 "
+                    "-device tmp105,bus=i2c-bus.0,id=" TMP105_TEST_ID
+                    ",address=0x49");
     i2c = omap_i2c_create(OMAP2_I2C_1_BASE);
-    addr = N8X0_ADDR;
 
     qtest_add_func("/tmp105/tx-rx", send_and_receive);
 
-- 
1.9.0

  parent reply	other threads:[~2014-03-31 16:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 16:26 [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes Paolo Bonzini
2014-03-31 16:26 ` [Qemu-devel] [PATCH for-2.0 1/7] smbus: allow returning an error from reads Paolo Bonzini
2014-03-31 21:20   ` Andreas Färber
2014-03-31 16:26 ` [Qemu-devel] [PATCH for-2.0 2/7] smbus: return -1 if nothing found at the given address Paolo Bonzini
2014-03-31 21:29   ` Andreas Färber
2014-03-31 16:26 ` [Qemu-devel] [PATCH for-2.0 3/7] pm_smbus: correctly report unclaimed cycles Paolo Bonzini
2014-03-31 21:38   ` Andreas Färber
2014-03-31 16:26 ` [Qemu-devel] [PATCH for-2.0 4/7] tmp105: read temperature in milli-celsius Paolo Bonzini
2014-03-31 16:26 ` [Qemu-devel] [PATCH for-2.0 5/7] tmp105-test: wrap simple building blocks for testing Paolo Bonzini
2014-03-31 16:26 ` Paolo Bonzini [this message]
2014-03-31 21:01   ` [Qemu-devel] [PATCH for-2.0 6/7] tmp105-test: add a second sensor and test that one Andreas Färber
2014-03-31 16:26 ` [Qemu-devel] [PATCH for-2.0 7/7] tmp105-test: test QOM property and precision Paolo Bonzini
2014-03-31 21:58 ` [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes Andreas Färber
2014-04-02 15:55   ` Michael S. Tsirkin
2014-04-02 15:58     ` Paolo Bonzini
2014-05-07  8:03     ` Paolo Bonzini
2014-05-07  9:02       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396283195-6819-7-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).