From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44112)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WUs6O-0004g4-C5
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 02:23:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WUs6I-0000ai-6z
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 02:23:16 -0400
Message-ID: <1396333381.17363.3.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 01 Apr 2014 08:23:01 +0200
In-Reply-To: <CAFEAcA97JW2JdaXLJyqJ-K+_0Gm0jt6Th4HdwnL3RJEAW6Bkog@mail.gmail.com>
References: <1396275242-10810-1-git-send-email-mst@redhat.com>
	<1396275242-10810-25-git-send-email-mst@redhat.com>
	<CAFEAcA97JW2JdaXLJyqJ-K+_0Gm0jt6Th4HdwnL3RJEAW6Bkog@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 24/30] usb: sanity check
 setup_index+setup_len in post_load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-stable <qemu-stable@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Dave Gilbert <dgilbert@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>


> > +    if (dev->setup_index >= sizeof(dev->data_buf) ||
> > +        dev->setup_len >= sizeof(dev->data_buf)) {
> > +        return -EINVAL;
> > +    }
> >      return 0;
> >  }
> 
> (2) Shouldn't we be checking for setup_index and setup_len
> being negative as well?

Oops, they are signed, so yes, I guess we should.  Or we can just make
them unsigned, they should never ever be negative.  But I'm not fully
sure we can do that without breaking migration ...

cheers,
  Gerd