From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44753)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WUs9F-0002rn-KI
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 02:26:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WUs98-0001GW-JO
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 02:26:13 -0400
Message-ID: <1396333560.17363.4.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 01 Apr 2014 08:26:00 +0200
In-Reply-To: <1396303746-1858-1-git-send-email-kroosec@gmail.com>
References: <1396303746-1858-1-git-send-email-kroosec@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] input: mouse_set should check input
	device type.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, aliguori@amazon.com, armbru@redhat.com

On Mo, 2014-03-31 at 23:09 +0100, Hani Benhabiles wrote:
> Otherwise, the index of an input device like a usb-kbd is silently
> accepted.
> 
> (qemu) info mice
>   Mouse #2: QEMU PS/2 Mouse
> * Mouse #3: QEMU HID Mouse
> (qemu) mouse_set 1
> (qemu) info mice
>   Mouse #2: QEMU PS/2 Mouse
> * Mouse #3: QEMU HID Mouse
> 
> Also replace monitor_printf() call in do_mouse_set() with
> error_report() and
> adjust error message.

Added to input patch queue.

thanks,
  Gerd