From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV1w5-0004it-CM for qemu-devel@nongnu.org; Tue, 01 Apr 2014 12:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WV1w4-0001HV-4o for qemu-devel@nongnu.org; Tue, 01 Apr 2014 12:53:17 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:47425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV1w3-0001GU-Vd for qemu-devel@nongnu.org; Tue, 01 Apr 2014 12:53:16 -0400 From: Peter Maydell Date: Tue, 1 Apr 2014 17:53:02 +0100 Message-Id: <1396371187-8567-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 0/5] stellaris_enet: overhaul TX handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , patches@linaro.org This patchset fixes the stellaris_enet TX handling code. The principal motivation is to fix the buffer overrun noted in the first patch, and to remove tx_fifo_len from the state (which completely sidesteps the question of how to validate it in incoming migration state :-)). I also fixed a couple of other bugs I noticed while I was there. This isn't actually sufficient to get my test image to work: that needs proper implementation of the MII registers in the PHY. I tested this with a minor hack to make all MII registers return 0x24, which happens to satisfy the test image's setup code. However implementing the PHY registers is more work than I want to do on this device right now... Peter Maydell (5): hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun hw/net/stellaris_enet: Correct handling of packet padding hw/net/stellaris_enet: Rewrite tx fifo handling code hw/net/stellaris_enet: Correctly implement the TR and THR registers hw/net/stellaris_enet: Fix debug format strings hw/net/stellaris_enet.c | 128 +++++++++++++++++++++++++++++++++--------------- 1 file changed, 88 insertions(+), 40 deletions(-) -- 1.9.0