* [Qemu-devel] [PATCH 2.0] PPC: openpic_kvm: Filter memory events properly
@ 2014-04-02 9:41 Alexander Graf
2014-04-02 17:52 ` Scott Wood
2014-04-03 11:59 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Graf @ 2014-04-02 9:41 UTC (permalink / raw)
To: qemu-devel
Cc: scottwood, Peter Maydell, prasadjoshi.linux, qemu-ppc, afaerber
Commit 6f1834a2b exposed a bug in openpic_kvm where we don't filter
for memory events that only happen to the region we want to know
events about.
Add proper filtering, fixing the e500plat target with KVM.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
hw/intc/openpic_kvm.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c
index afa604d..6635407 100644
--- a/hw/intc/openpic_kvm.c
+++ b/hw/intc/openpic_kvm.c
@@ -118,6 +118,11 @@ static void kvm_openpic_region_add(MemoryListener *listener,
abort();
}
+ /* Ignore events on regions that are not us */
+ if (section->mr != &opp->mem) {
+ return;
+ }
+
reg_base = section->offset_within_address_space;
attr.group = KVM_DEV_MPIC_GRP_MISC;
@@ -140,6 +145,11 @@ static void kvm_openpic_region_del(MemoryListener *listener,
uint64_t reg_base = 0;
int ret;
+ /* Ignore events on regions that are not us */
+ if (section->mr != &opp->mem) {
+ return;
+ }
+
attr.group = KVM_DEV_MPIC_GRP_MISC;
attr.attr = KVM_DEV_MPIC_BASE_ADDR;
attr.addr = (uint64_t)(unsigned long)®_base;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 2.0] PPC: openpic_kvm: Filter memory events properly
2014-04-02 9:41 [Qemu-devel] [PATCH 2.0] PPC: openpic_kvm: Filter memory events properly Alexander Graf
@ 2014-04-02 17:52 ` Scott Wood
2014-04-03 11:59 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Scott Wood @ 2014-04-02 17:52 UTC (permalink / raw)
To: Alexander Graf
Cc: Peter Maydell, prasadjoshi.linux, qemu-ppc, qemu-devel, afaerber
On Wed, 2014-04-02 at 11:41 +0200, Alexander Graf wrote:
> Commit 6f1834a2b exposed a bug in openpic_kvm where we don't filter
> for memory events that only happen to the region we want to know
> events about.
>
> Add proper filtering, fixing the e500plat target with KVM.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Acked-by: Scott Wood <scottwood@freescale.com>
-Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 2.0] PPC: openpic_kvm: Filter memory events properly
2014-04-02 9:41 [Qemu-devel] [PATCH 2.0] PPC: openpic_kvm: Filter memory events properly Alexander Graf
2014-04-02 17:52 ` Scott Wood
@ 2014-04-03 11:59 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2014-04-03 11:59 UTC (permalink / raw)
To: Alexander Graf
Cc: Scott Wood, Prasad Joshi, qemu-ppc@nongnu.org, QEMU Developers,
Andreas Färber
On 2 April 2014 10:41, Alexander Graf <agraf@suse.de> wrote:
> Commit 6f1834a2b exposed a bug in openpic_kvm where we don't filter
> for memory events that only happen to the region we want to know
> events about.
>
> Add proper filtering, fixing the e500plat target with KVM.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-03 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 9:41 [Qemu-devel] [PATCH 2.0] PPC: openpic_kvm: Filter memory events properly Alexander Graf
2014-04-02 17:52 ` Scott Wood
2014-04-03 11:59 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).