From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVKY9-0004qV-8Q for qemu-devel@nongnu.org; Wed, 02 Apr 2014 08:45:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVKY2-0003Jj-O4 for qemu-devel@nongnu.org; Wed, 02 Apr 2014 08:45:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVKY2-0003J4-0f for qemu-devel@nongnu.org; Wed, 02 Apr 2014 08:45:42 -0400 From: Paolo Bonzini Date: Wed, 2 Apr 2014 14:45:28 +0200 Message-Id: <1396442728-32321-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH for-2.0] iscsi: recognize "invalid field" ASCQ from WRITE SAME command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pl@kamp.de Some targets may return "invalid field" as the ASCQ from WRITE SAME if they support the command only without the UNMAP field. Recognize that, and return ENOTSUP just like for "invalid operation code". Signed-off-by: Paolo Bonzini --- block/iscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6d6cd4f..f01c883 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1012,7 +1012,8 @@ retry: if (iTask.status == SCSI_STATUS_CHECK_CONDITION && iTask.task->sense.key == SCSI_SENSE_ILLEGAL_REQUEST && - iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE) { + (iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE || + iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB)) { /* WRITE SAME is not supported by the target */ iscsilun->has_write_same = false; scsi_free_scsi_task(iTask.task); -- 1.9.0